From: Andrew Grover <andy.grover@gmail.com>
To: netdev@oss.sgi.com
Subject: [PATCH] Add more explanation to tcp_prequeue comment
Date: Thu, 28 Apr 2005 14:14:13 -0700 [thread overview]
Message-ID: <c0a09e5c05042814145901639e@mail.gmail.com> (raw)
Here's a patch to make that prequeue comment a little clearer. Look ok?
Signed-off-by: Andy Grover <andrew.grover@intel.com>
===== include/net/tcp.h 1.105 vs edited =====
--- 1.105/include/net/tcp.h 2005-02-22 10:45:31 -08:00
+++ edited/include/net/tcp.h 2005-04-28 14:02:43 -07:00
@@ -1560,6 +1560,13 @@
* idea (VJ's mail "Re: query about TCP header on tcp-ip" of 07 Sep 93)
* failed somewhere. Latency? Burstiness? Well, at least now we will
* see, why it failed. 8)8) --ANK
+ *
+ * Actually, even though the prequeue is not as important for fast
+ * csum anymore, it is important for scheduling, to generate ACKs
+ * when the data is received by the process, not the stack.
+ * davem says, "Without prequeue, we ACK immediately. This artificially
+ * makes the sender believe it can pump data out at that rate to the
+ * receiver."
*
* NOTE: is this not too big to inline?
*/
next reply other threads:[~2005-04-28 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 21:14 Andrew Grover [this message]
2005-04-28 21:53 ` [PATCH] Add more explanation to tcp_prequeue comment Arnaldo Carvalho de Melo
2005-05-03 21:30 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0a09e5c05042814145901639e@mail.gmail.com \
--to=andy.grover@gmail.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).