setsockopt option struct with an address?

setsockopt option struct with an address?

[Andrew Grover]

Hi all, I'm looking for some advice on defining a new interface.

RDS has an existing interface to prepare a memory region for use in an
RDMA operation, called GET_MR. (see include/linux/rds.h). It basically
takes an address and length, and returns a handle that later commands
use to reference the region.

We need to add an additional sockopt that also passes in the remote
host's address, because the current method for defining memory regions
binds their use to a particular remote host only.

Here's the original sockopt's args:

struct rds_get_mr_args {
        struct rds_iovec vec;
        u_int64_t       cookie_addr;
        uint64_t        flags;
};

Here is a swag at the new sockopt's args:

struct rds_get_mr_for_dest_args {
        u_int32_t       dest_addr;   /*   added this */
        struct rds_iovec vec;
        u_int64_t       cookie_addr;
        uint64_t        flags;
};

Or should the added member be a struct sockaddr, or a sockaddr_in, or
a sockaddr_storage, or what? And should it be a pointer to that
struct, or embedded?

Much thanks -- Regards -- Andy

Re: setsockopt option struct with an address?

[David Miller]

From: Andrew Grover <andy.grover@gmail.com>
Date: Thu, 1 Oct 2009 13:17:03 -0700

> Or should the added member be a struct sockaddr, or a sockaddr_in, or
> a sockaddr_storage, or what? And should it be a pointer to that
> struct, or embedded?

You probably should use sockaddr_storage, I mean you will want to
support ipv6 at some point right? :-)