From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: next-20210302 - build issue with linux-firmware and rtl_nic/ firmware.
Date: Wed, 3 Mar 2021 11:26:11 +0100 [thread overview]
Message-ID: <c0a272c2-1e7d-022a-88b6-29fca298e7d7@gmail.com> (raw)
In-Reply-To: <205633.1614757174@turing-police>
On 03.03.2021 08:39, Valdis Klētnieks wrote:
> On Wed, 03 Mar 2021 07:51:06 +0100, Heiner Kallweit said:
>>> # Firmware loader
>>> CONFIG_EXTRA_FIRMWARE="rtl_nic/rtl8106e-1.fw"
>>> CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
>>>
>> This is wrong, simply remove it.
>
>>> But then I take a closer look at drivers/net/ethernet/realtek/r8169_main.c
>>> #define FIRMWARE_8168D_1 "rtl_nic/rtl8168d-1.fw"
>>> #define FIRMWARE_8168D_2 "rtl_nic/rtl8168d-2.fw"
>>> #define FIRMWARE_8168E_1 "rtl_nic/rtl8168e-1.fw"
>
> Yes, but then how are *these* filenames supposed to work? Is a userspace helper
> supposed to be smart enough to append the .xz, and the EXTRA_FIRMWARE variant
> for embedding out-of-tree firmware has to point at an uncompressed version?
>
There is no such thing as compressed firmware files, see here:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/rtl_nic
Your issue may be distro-specific, so you should check in a support forum of
your respective distro.
prev parent reply other threads:[~2021-03-04 0:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 6:09 next-20210302 - build issue with linux-firmware and rtl_nic/ firmware Valdis Klētnieks
2021-03-03 6:51 ` Heiner Kallweit
2021-03-03 7:39 ` Valdis Klētnieks
2021-03-03 10:26 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0a272c2-1e7d-022a-88b6-29fca298e7d7@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).