From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH 1/5] netlink: extended ACK reporting Date: Thu, 13 Apr 2017 15:27:31 +0200 Message-ID: References: <20170408174900.12820-1-johannes@sipsolutions.net> <20170408174900.12820-2-johannes@sipsolutions.net> <20170408183440.GA1900@nanopsycho> <1491676621.5800.24.camel@sipsolutions.net> <20170408184008.GB1900@nanopsycho> <990b5610-a894-b3d2-d3a7-536dfd25adb8@cumulusnetworks.com> <1491805089.2455.3.camel@sipsolutions.net> Reply-To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, Jamal Hadi Salim , Jiri Benc To: Johannes Berg , David Ahern , Jiri Pirko Return-path: In-Reply-To: <1491805089.2455.3.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Le 10/04/2017 à 08:18, Johannes Berg a écrit : > >> perhaps I misunderstand something, but nla_parse suggests attribute >> type can not be 0: > [...] > > Yes, some - very few - families still insist on using attribute 0, > perhaps parsing by hand or so. Like you say though, the entire > infrastructure makes that hard and undesirable, so I don't really see > why we need to invest the extra code/work into making it work *here*, > especially since it's such a corner case as I described in my other > email. Here is an example: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=31e20bad8d58 I also see one in openvswitch (I will send a similar patch), but there are probably some others. Regards, Nicolas