From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Vikas Gupta <vikas.gupta@broadcom.com>
Cc: bhargava.marreddy@broadcom.com, rajashekar.hudumula@broadcom.com,
netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
Date: Fri, 30 Jan 2026 14:10:50 +0530 [thread overview]
Message-ID: <c102db6f-c676-4bb9-a1ee-3a43b35e6290@oracle.com> (raw)
In-Reply-To: <CAHLZf_vxzcOpavJ-rNUsmi3XQ-NAqmWBvy2MRgGb2A3iWFHFHw@mail.gmail.com>
On 1/30/2026 2:05 PM, Vikas Gupta wrote:
>> drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>> index a987afebd64d..57db3caabcfb 100644
>> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
>> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>> if (rc) {
>> NL_SET_ERR_MSG_MOD(extack,
>> - "Failed to set roce firmware version");
>> + "Failed to set generic firmware version");
> Thanks for fixing. I believe instead of generic, "Failed to set
> firmware version" is enough.
ACK. will send v2.
>
>> return rc;
>> }
>>
>> --
Thanks,
Alok
next prev parent reply other threads:[~2026-01-30 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 7:30 [PATCH net-next] bng_en: fix misleading error message for generic firmware version Alok Tiwari
2026-01-30 8:35 ` Vikas Gupta
2026-01-30 8:40 ` ALOK TIWARI [this message]
2026-01-30 13:06 ` Bhargava Chenna Marreddy
2026-01-30 13:40 ` ALOK TIWARI
2026-01-30 15:52 ` Bhargava Chenna Marreddy
2026-01-31 1:13 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c102db6f-c676-4bb9-a1ee-3a43b35e6290@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox