From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, mptcp@lists.01.org,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next] mptcp: be careful on MPTCP-level ack.
Date: Tue, 24 Nov 2020 19:53:10 +0100 [thread overview]
Message-ID: <c110f036c113f3b8154c8671ce376d555b6f2b5a.camel@redhat.com> (raw)
In-Reply-To: <20201124100809.08360e4c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Tue, 2020-11-24 at 10:08 -0800, Jakub Kicinski wrote:
> On Tue, 24 Nov 2020 12:20:11 +0100 Paolo Abeni wrote:
> > -static void mptcp_send_ack(struct mptcp_sock *msk, bool force)
> > +static inline bool tcp_can_send_ack(const struct sock *ssk)
> > +{
> > + return !((1 << inet_sk_state_load(ssk)) &
> > + (TCPF_SYN_SENT | TCPF_SYN_RECV | TCPF_TIME_WAIT | TCPF_CLOSE));
> > +}
>
> Does the compiler really not inline this trivial static function?
whoops... That is just me adding an unneeded keyword. I'll send a v2.
Thanks,
Paolo
prev parent reply other threads:[~2020-11-24 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 11:20 [PATCH net-next] mptcp: be careful on MPTCP-level ack Paolo Abeni
2020-11-24 18:08 ` Jakub Kicinski
2020-11-24 18:53 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c110f036c113f3b8154c8671ce376d555b6f2b5a.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).