From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] pktgen: Remove VLA usage Date: Fri, 9 Mar 2018 12:33:23 -0600 Message-ID: References: <20180309054340.GA14439@embeddedgus> <20180309.115810.954232560207995724.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller , gustavo@embeddedor.com Return-path: In-Reply-To: <20180309.115810.954232560207995724.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 03/09/2018 10:58 AM, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Thu, 8 Mar 2018 23:43:40 -0600 > >> In preparation to enabling -Wvla, remove VLA usage and replace it >> with a fixed-length array instead. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> David, >> >> I'm not sure how often this function is being called and, >> depending on the frequency it may be worth to use >> dynamic memory allocation instead? > > It happens every time a config setting is made via the sysfs > files when debug is enabled. > > This is not something that happens often. > I got it. > So your patch is fine, applied to net-next, thanks. > Awesome. Thanks, David. -- Gustavo