From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 254B919F422; Wed, 18 Dec 2024 11:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734523092; cv=none; b=NugkAKuUN3jdBAYzvrLe0FDs9SZFrJu58QJWKtT07Ji08xUAhCYadm048y+cMX7vbURo+JGruuSqgkun2OphaCoAW6RdDK4OllDRVNBRukQytgYWOaxB6YlSFZ3tAS/QbPy9LBbWsTMR59vwEtKPXBNQOA6Ty3iGadBQNQjf3ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734523092; c=relaxed/simple; bh=EAnyg44bc5X50AIbEYTrPKtqShTc5lDAgEa+nBxLaGo=; h=Message-ID:Date:MIME-Version:CC:Subject:To:References:From: In-Reply-To:Content-Type; b=tqQUuSfaOy3f37HLmX5BkmzLnLwqRO0rkEY1KUK0Bo6kNHVUGztSvTKe3BPmIedZFFygJyeSdjmAVcmzeRhziUhbUd3jfLhLabM+kdGooNMlZzYnBne8f7alv7JmeRPdqSNdmD+Q+qa77u7x5dn4qJ3byuaaupKvdu+8/xlhdAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YCsZC48XGz2DjBs; Wed, 18 Dec 2024 19:55:31 +0800 (CST) Received: from kwepemk100013.china.huawei.com (unknown [7.202.194.61]) by mail.maildlp.com (Postfix) with ESMTPS id 5485F140391; Wed, 18 Dec 2024 19:58:06 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemk100013.china.huawei.com (7.202.194.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 18 Dec 2024 19:58:05 +0800 Message-ID: Date: Wed, 18 Dec 2024 19:58:04 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , Subject: Re: [PATCH net-next 2/3] net: hisilicon: hns: Remove unused hns_rcb_start To: , , , , , , , References: <20241218005729.244987-1-linux@treblig.org> <20241218005729.244987-3-linux@treblig.org> From: Jijie Shao In-Reply-To: <20241218005729.244987-3-linux@treblig.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemk100013.china.huawei.com (7.202.194.61) on 2024/12/18 8:57, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > hns_rcb_start() has been unused since 2016's > commit 454784d85de3 ("net: hns: delete redundancy ring enable operations") > > Remove it. Thanks, Reviewed-by: Jijie Shao > > Signed-off-by: Dr. David Alan Gilbert > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 5 ----- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h | 1 - > 2 files changed, 6 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c > index 46af467aa596..635b3a95dd82 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c > @@ -195,11 +195,6 @@ void hns_rcb_ring_enable_hw(struct hnae_queue *q, u32 val) > dsaf_write_dev(q, RCB_RING_PREFETCH_EN_REG, !!val); > } > > -void hns_rcb_start(struct hnae_queue *q, u32 val) > -{ > - hns_rcb_ring_enable_hw(q, val); > -} > - > /** > *hns_rcb_common_init_commit_hw - make rcb common init completed > *@rcb_common: rcb common device > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h > index 0f4cc184ef39..68f81547dfb4 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h > @@ -116,7 +116,6 @@ int hns_rcb_buf_size2type(u32 buf_size); > int hns_rcb_common_get_cfg(struct dsaf_device *dsaf_dev, int comm_index); > void hns_rcb_common_free_cfg(struct dsaf_device *dsaf_dev, u32 comm_index); > int hns_rcb_common_init_hw(struct rcb_common_cb *rcb_common); > -void hns_rcb_start(struct hnae_queue *q, u32 val); > int hns_rcb_get_cfg(struct rcb_common_cb *rcb_common); > void hns_rcb_get_queue_mode(enum dsaf_mode dsaf_mode, > u16 *max_vfn, u16 *max_q_per_vf);