From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>,
netdev@vger.kernel.org
Cc: tglx@linutronix.de, jan.altenberg@linutronix.de,
vinicius.gomes@intel.com, kurt.kanzenbach@linutronix.de,
henrik@austad.us, richardcochran@gmail.com,
levi.pearson@harman.com, ilias.apalodimas@linaro.org,
ivan.khoronzhuk@linaro.org, mlichvar@redhat.com,
willemb@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, Richard Cochran <rcochran@linutronix.de>
Subject: Re: [PATCH v1 net-next 02/14] net: Add a new socket option for a future transmit time.
Date: Wed, 27 Jun 2018 15:16:59 -0700 [thread overview]
Message-ID: <c133ef6d-120c-52fb-e6bb-f33da5badb27@gmail.com> (raw)
In-Reply-To: <20180627215950.6719-3-jesus.sanchez-palencia@intel.com>
On 06/27/2018 02:59 PM, Jesus Sanchez-Palencia wrote:
> From: Richard Cochran <rcochran@linutronix.de>
>
> This patch introduces SO_TXTIME. User space enables this option in
> order to pass a desired future transmit time in a CMSG when calling
> sendmsg(2). The argument to this socket option is a 6-bytes long struct
> defined as:
>
> struct sock_txtime {
> clockid_t clockid;
> u16 flags;
> };
Note that sizeof(struct sock_txtime) is 8, not 6, because of alignments.
This means that your implementation of getsockopt(... SO_TXTIME )
is probably leaking two bytes of kernel stack to user space.
next prev parent reply other threads:[~2018-06-27 22:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 21:59 [PATCH v1 net-next 00/14] Scheduled packet Transmission: ETF Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 01/14] net: Clear skb->tstamp only on the forwarding path Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 02/14] net: Add a new socket option for a future transmit time Jesus Sanchez-Palencia
2018-06-27 22:16 ` Eric Dumazet [this message]
2018-06-27 23:07 ` Jesus Sanchez-Palencia
2018-06-28 0:05 ` Eric Dumazet
2018-06-28 2:16 ` kbuild test robot
2018-06-28 14:26 ` Willem de Bruijn
2018-06-28 14:40 ` Willem de Bruijn
2018-06-28 18:33 ` Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 03/14] net: ipv4: Hook into time based transmission Jesus Sanchez-Palencia
2018-06-28 14:26 ` Willem de Bruijn
2018-06-27 21:59 ` [PATCH v1 net-next 04/14] net: packet: " Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 05/14] net/sched: Allow creating a Qdisc watchdog with other clocks Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 06/14] net/sched: Introduce the ETF Qdisc Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 07/14] net/sched: Add HW offloading capability to ETF Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 08/14] igb: Refactor igb_configure_cbs() Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 09/14] igb: Only change Tx arbitration when CBS is on Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 10/14] igb: Refactor igb_offload_cbs() Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 11/14] igb: Add support for ETF offload Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 12/14] igb: Only call skb_tx_timestamp after descriptors are ready Jesus Sanchez-Palencia
2018-06-27 23:56 ` Eric Dumazet
2018-06-28 17:12 ` Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 13/14] net/sched: Enforce usage of CLOCK_TAI for sch_etf Jesus Sanchez-Palencia
2018-06-28 14:26 ` Willem de Bruijn
2018-06-28 17:11 ` Jesus Sanchez-Palencia
2018-06-27 21:59 ` [PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue Jesus Sanchez-Palencia
2018-06-28 14:27 ` Willem de Bruijn
2018-06-29 17:48 ` Jesus Sanchez-Palencia
2018-06-29 18:49 ` Willem de Bruijn
2018-06-29 20:14 ` Jesus Sanchez-Palencia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c133ef6d-120c-52fb-e6bb-f33da5badb27@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=henrik@austad.us \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jan.altenberg@linutronix.de \
--cc=jesus.sanchez-palencia@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kurt.kanzenbach@linutronix.de \
--cc=levi.pearson@harman.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rcochran@linutronix.de \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=vinicius.gomes@intel.com \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).