From mboxrd@z Thu Jan 1 00:00:00 1970 From: YueHaibing Subject: Re: [PATCH net-next] NFC: nci: remove redundant variable 'status' Date: Thu, 13 Sep 2018 20:06:59 +0800 Message-ID: References: <20180801072020.14696-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , To: , Return-path: In-Reply-To: <20180801072020.14696-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Ping. On 2018/8/1 15:20, YueHaibing wrote: > After commit d8cd37ed2fc8 ("NFC: nci: Fix improper management of HCI return code") > variable 'status' is being assigned but never used, > so can be removed. Also make a trival cleanup. > > Signed-off-by: YueHaibing > --- > net/nfc/nci/hci.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c > index ddfc52a..4debba8 100644 > --- a/net/nfc/nci/hci.c > +++ b/net/nfc/nci/hci.c > @@ -370,17 +370,11 @@ static void nci_hci_resp_received(struct nci_dev *ndev, u8 pipe, > u8 result, struct sk_buff *skb) > { > struct nci_conn_info *conn_info; > - u8 status = result; > > conn_info = ndev->hci_dev->conn_info; > - if (!conn_info) { > - status = NCI_STATUS_REJECTED; > - goto exit; > - } > - > - conn_info->rx_skb = skb; > + if (conn_info) > + conn_info->rx_skb = skb; > > -exit: > nci_req_complete(ndev, NCI_STATUS_OK); > } > >