From: Igor Druzhinin <igor.druzhinin@citrix.com>
To: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()
Date: Tue, 2 Feb 2021 15:26:03 +0000 [thread overview]
Message-ID: <c17d4e45-cad1-510d-0e7b-9d95af89ff01@citrix.com> (raw)
In-Reply-To: <20210202070938.7863-1-jgross@suse.com>
On 02/02/2021 07:09, Juergen Gross wrote:
> Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding")
> xenvif_rx_ring_slots_available() is no longer called only from the rx
> queue kernel thread, so it needs to access the rx queue with the
> associated queue held.
>
> Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> Fixes: 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding")
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Appreciate a quick fix! Is this the only place that sort of race could
happen now?
Igor
next prev parent reply other threads:[~2021-02-02 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 7:09 [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available() Juergen Gross
2021-02-02 15:26 ` Igor Druzhinin [this message]
2021-02-02 16:12 ` Jürgen Groß
2021-02-02 16:22 ` Wei Liu
2021-02-03 23:48 ` Jakub Kicinski
2021-02-04 5:32 ` Jürgen Groß
2021-02-05 1:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c17d4e45-cad1-510d-0e7b-9d95af89ff01@citrix.com \
--to=igor.druzhinin@citrix.com \
--cc=davem@davemloft.net \
--cc=jgross@suse.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=stable@vger.kernel.org \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).