From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9293CC433E0 for ; Tue, 2 Feb 2021 15:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6012E64F6B for ; Tue, 2 Feb 2021 15:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235632AbhBBPf1 (ORCPT ); Tue, 2 Feb 2021 10:35:27 -0500 Received: from esa6.hc3370-68.iphmx.com ([216.71.155.175]:22447 "EHLO esa6.hc3370-68.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234995AbhBBPcq (ORCPT ); Tue, 2 Feb 2021 10:32:46 -0500 X-Greylist: delayed 323 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Feb 2021 10:32:43 EST DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1612279966; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=Ff0ODS3QBH1c9Z92pXmSGi2ISsoawY8OQVKLEOisOdI=; b=AlIWjYGiPo/Ba/sCiDaBeEurUVa29SgQFaEW5LDX6VQ7gkpLjKaPA/bA +MbDNhxXarP6uwEkeAck9sLAdhyuME8sE8uEEk0sQhXY71S3JgcspXDmI nvnBvhiMv3KoXU+odPjFoYw+batTOQnR7dcjC4Gf0XJWwDj4KTVy5Xme6 U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 3AsF6jWq0gMIIKS1cdsb7GcLWobd5iEgdpRkCEPFI/T0bE6dBMaAKwJkpHPCPlXUy/8L47yPoS Ir3YOcLKU9ZljJFLU9/qevKmpLia6n5Sxb07p+ObyagjNGHumtyIZpHjAB0tR0r07ONc+/1ISv Y/yNHDRdozIUNz423FFx0RtDiWaEYE7Z+3VKZeSybNrBBmiYxvZ+3HsAZ4L4yRPYIRHnnTsW/6 cTW7rS0ki5wDxJAo3EjtAadZ0L0c7NDOMnO0zRsJkKSOCADBCbV1BvOZQjU+vQUfMDL/QbE5Y6 NdU= X-SBRS: 5.1 X-MesageID: 36576887 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.79,395,1602561600"; d="scan'208";a="36576887" Subject: Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available() To: Juergen Gross , , , CC: Wei Liu , Paul Durrant , "David S. Miller" , Jakub Kicinski , References: <20210202070938.7863-1-jgross@suse.com> From: Igor Druzhinin Message-ID: Date: Tue, 2 Feb 2021 15:26:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210202070938.7863-1-jgross@suse.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/02/2021 07:09, Juergen Gross wrote: > Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") > xenvif_rx_ring_slots_available() is no longer called only from the rx > queue kernel thread, so it needs to access the rx queue with the > associated queue held. > > Reported-by: Igor Druzhinin > Fixes: 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") > Cc: stable@vger.kernel.org > Signed-off-by: Juergen Gross Appreciate a quick fix! Is this the only place that sort of race could happen now? Igor