netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	Woojung.Huh@microchip.com
Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch,
	vivien.didelot@savoirfairelinux.com,
	driverdev-devel@linuxdriverproject.org, davem@davemloft.net,
	netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
Date: Mon, 17 Dec 2018 14:22:23 -0800	[thread overview]
Message-ID: <c1922554-48e4-8158-00a5-e1cba4660d85@gmail.com> (raw)
In-Reply-To: <20181217204423.14271-1-sergio.paracuellos@gmail.com>

On 12/17/18 12:44 PM, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

This looks good, although it looks like you have 2x the amount of tabs
necessary.
-- 
Florian

  reply	other threads:[~2018-12-17 22:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 20:44 [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Sergio Paracuellos
2018-12-17 22:22 ` Florian Fainelli [this message]
2018-12-18  6:32   ` Sergio Paracuellos
2018-12-18 15:10 ` Rob Herring
2018-12-19  6:23   ` Sergio Paracuellos
2018-12-19 18:26     ` Florian Fainelli
2018-12-19 19:49       ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1922554-48e4-8158-00a5-e1cba4660d85@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).