From: David Ahern <dsahern@gmail.com>
To: Parav Pandit <parav@nvidia.com>,
stephen@networkplumber.org, netdev@vger.kernel.org
Cc: Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH iproute2-next 5/5] devlink: Support set of port function state
Date: Sun, 31 Jan 2021 10:30:39 -0700 [thread overview]
Message-ID: <c197fd9c-c6a8-0ad1-1dce-c439d891354c@gmail.com> (raw)
In-Reply-To: <20210129165608.134965-6-parav@nvidia.com>
On 1/29/21 9:56 AM, Parav Pandit wrote:
> @@ -1420,6 +1423,22 @@ static int port_flavour_parse(const char *flavour, uint16_t *value)
> }
> }
>
> +static int port_function_state_parse(const char *statestr, uint8_t *state)
> +{
> + if (!statestr)
> + return -EINVAL;
> +
> + if (strcmp(statestr, "inactive") == 0) {
> + *state = DEVLINK_PORT_FN_STATE_INACTIVE;
> + return 0;
> + } else if (strcmp(statestr, "active") == 0) {
> + *state = DEVLINK_PORT_FN_STATE_ACTIVE;
> + return 0;
> + } else {
> + return -EINVAL;
> + }
> +}
> +
if another state gets added this too should be table driven - string to
type here and the inverse in the previous patch.
> struct dl_args_metadata {
> uint64_t o_flag;
> char err_msg[DL_ARGS_REQUIRED_MAX_ERR_LEN];
> @@ -3897,7 +3934,6 @@ static void pr_out_port_function(struct dl *dl, struct nlattr **tb_port)
>
> print_string(PRINT_ANY, "opstate", " opstate %s", port_function_opstate(state));
> }
> -
> if (!dl->json_output)
> __pr_out_indent_dec();
> pr_out_object_end(dl);
Removing the newline intentional?
next prev parent reply other threads:[~2021-01-31 20:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 16:56 [PATCH iproute2-next 0/5] Support devlink port add delete Parav Pandit
2021-01-29 16:56 ` [PATCH iproute2-next 1/5] devlink: Update kernel headers Parav Pandit
2021-01-29 16:56 ` [PATCH iproute2-next 2/5] devlink: Introduce PCI SF port flavour and attribute Parav Pandit
2021-01-29 16:56 ` [PATCH iproute2-next 3/5] devlink: Supporting add and delete of devlink port Parav Pandit
2021-01-31 17:26 ` David Ahern
2021-02-01 20:42 ` Parav Pandit
2021-01-29 16:56 ` [PATCH iproute2-next 4/5] devlink: Support get port function state Parav Pandit
2021-01-29 16:56 ` [PATCH iproute2-next 5/5] devlink: Support set of " Parav Pandit
2021-01-31 17:30 ` David Ahern [this message]
2021-02-01 20:50 ` Parav Pandit
2021-02-01 21:35 ` [PATCH iproute2-next v2 0/6] Support devlink port add delete Parav Pandit
2021-02-01 21:35 ` [PATCH iproute2-next v2 1/6] devlink: Update kernel headers Parav Pandit
2021-02-01 21:35 ` [PATCH iproute2-next v2 2/6] devlink: Introduce and use string to number mapper Parav Pandit
2021-02-01 21:35 ` [PATCH iproute2-next v2 3/6] devlink: Introduce PCI SF port flavour and attribute Parav Pandit
2021-02-01 21:35 ` [PATCH iproute2-next v2 4/6] devlink: Supporting add and delete of devlink port Parav Pandit
2021-02-01 21:35 ` [PATCH iproute2-next v2 5/6] devlink: Support get port function state Parav Pandit
2021-02-01 21:35 ` [PATCH iproute2-next v2 6/6] devlink: Support set of " Parav Pandit
2021-02-02 3:20 ` [PATCH iproute2-next v2 0/6] Support devlink port add delete David Ahern
2021-02-02 4:01 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c197fd9c-c6a8-0ad1-1dce-c439d891354c@gmail.com \
--to=dsahern@gmail.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).