* [PATCH net-next] bng_en: fix misleading error message for generic firmware version
@ 2026-01-30 7:30 Alok Tiwari
2026-01-30 8:35 ` Vikas Gupta
0 siblings, 1 reply; 7+ messages in thread
From: Alok Tiwari @ 2026-01-30 7:30 UTC (permalink / raw)
To: vikas.gupta, bhargava.marreddy, rajashekar.hudumula, netdev,
andrew+netdev, davem, edumazet, kuba, pabeni
Cc: alok.a.tiwari
The devlink info_get handler incorrectly reports "roce firmware" when
populating the generic firmware version field.
Update the error message to correctly describe the failing operation.
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
index a987afebd64d..57db3caabcfb 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
@@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
DEVLINK_INFO_VERSION_GENERIC_FW, buf);
if (rc) {
NL_SET_ERR_MSG_MOD(extack,
- "Failed to set roce firmware version");
+ "Failed to set generic firmware version");
return rc;
}
--
2.50.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
2026-01-30 7:30 [PATCH net-next] bng_en: fix misleading error message for generic firmware version Alok Tiwari
@ 2026-01-30 8:35 ` Vikas Gupta
2026-01-30 8:40 ` ALOK TIWARI
0 siblings, 1 reply; 7+ messages in thread
From: Vikas Gupta @ 2026-01-30 8:35 UTC (permalink / raw)
To: Alok Tiwari
Cc: bhargava.marreddy, rajashekar.hudumula, netdev, andrew+netdev,
davem, edumazet, kuba, pabeni
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
On Fri, Jan 30, 2026 at 1:01 PM Alok Tiwari <alok.a.tiwari@oracle.com> wrote:
>
> The devlink info_get handler incorrectly reports "roce firmware" when
> populating the generic firmware version field.
>
> Update the error message to correctly describe the failing operation.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> index a987afebd64d..57db3caabcfb 100644
> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
> if (rc) {
> NL_SET_ERR_MSG_MOD(extack,
> - "Failed to set roce firmware version");
> + "Failed to set generic firmware version");
Thanks for fixing. I believe instead of generic, "Failed to set
firmware version" is enough.
> return rc;
> }
>
> --
> 2.50.1
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5465 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
2026-01-30 8:35 ` Vikas Gupta
@ 2026-01-30 8:40 ` ALOK TIWARI
2026-01-30 13:06 ` Bhargava Chenna Marreddy
0 siblings, 1 reply; 7+ messages in thread
From: ALOK TIWARI @ 2026-01-30 8:40 UTC (permalink / raw)
To: Vikas Gupta
Cc: bhargava.marreddy, rajashekar.hudumula, netdev, andrew+netdev,
davem, edumazet, kuba, pabeni
On 1/30/2026 2:05 PM, Vikas Gupta wrote:
>> drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>> index a987afebd64d..57db3caabcfb 100644
>> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
>> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>> if (rc) {
>> NL_SET_ERR_MSG_MOD(extack,
>> - "Failed to set roce firmware version");
>> + "Failed to set generic firmware version");
> Thanks for fixing. I believe instead of generic, "Failed to set
> firmware version" is enough.
ACK. will send v2.
>
>> return rc;
>> }
>>
>> --
Thanks,
Alok
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
2026-01-30 8:40 ` ALOK TIWARI
@ 2026-01-30 13:06 ` Bhargava Chenna Marreddy
2026-01-30 13:40 ` ALOK TIWARI
0 siblings, 1 reply; 7+ messages in thread
From: Bhargava Chenna Marreddy @ 2026-01-30 13:06 UTC (permalink / raw)
To: ALOK TIWARI
Cc: Vikas Gupta, rajashekar.hudumula, netdev, andrew+netdev, davem,
edumazet, kuba, pabeni
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
On Fri, Jan 30, 2026 at 2:11 PM ALOK TIWARI <alok.a.tiwari@oracle.com> wrote:
>
>
>
> On 1/30/2026 2:05 PM, Vikas Gupta wrote:
> >> drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> >> index a987afebd64d..57db3caabcfb 100644
> >> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> >> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> >> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
> >> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
> >> if (rc) {
> >> NL_SET_ERR_MSG_MOD(extack,
> >> - "Failed to set roce firmware version");
> >> + "Failed to set generic firmware version");
> > Thanks for fixing. I believe instead of generic, "Failed to set
> > firmware version" is enough.
>
> ACK. will send v2.
Should this be a candidate for net with a Fixes tag?
Thanks,
Bhargava Marreddy
>
> >
> >> return rc;
> >> }
> >>
> >> --
>
> Thanks,
> Alok
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5496 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
2026-01-30 13:06 ` Bhargava Chenna Marreddy
@ 2026-01-30 13:40 ` ALOK TIWARI
2026-01-30 15:52 ` Bhargava Chenna Marreddy
2026-01-31 1:13 ` Jakub Kicinski
0 siblings, 2 replies; 7+ messages in thread
From: ALOK TIWARI @ 2026-01-30 13:40 UTC (permalink / raw)
To: Bhargava Chenna Marreddy
Cc: Vikas Gupta, rajashekar.hudumula, netdev, andrew+netdev, davem,
edumazet, kuba, pabeni
On 1/30/2026 6:36 PM, Bhargava Chenna Marreddy wrote:
>> On 1/30/2026 2:05 PM, Vikas Gupta wrote:
>>>> drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>>>> index a987afebd64d..57db3caabcfb 100644
>>>> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>>>> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>>>> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
>>>> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>>>> if (rc) {
>>>> NL_SET_ERR_MSG_MOD(extack,
>>>> - "Failed to set roce firmware version");
>>>> + "Failed to set generic firmware version");
>>> Thanks for fixing. I believe instead of generic, "Failed to set
>>> firmware version" is enough.
>> ACK. will send v2.
> Should this be a candidate for net with a Fixes tag?
I am open to either approach. It does not break functionality, but the
current message can be misleading so I am happy to tag it for net if you
think it’s appropriate.
>
> Thanks,
> Bhargava Marreddy
Thanks,
Alok
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
2026-01-30 13:40 ` ALOK TIWARI
@ 2026-01-30 15:52 ` Bhargava Chenna Marreddy
2026-01-31 1:13 ` Jakub Kicinski
1 sibling, 0 replies; 7+ messages in thread
From: Bhargava Chenna Marreddy @ 2026-01-30 15:52 UTC (permalink / raw)
To: ALOK TIWARI
Cc: Vikas Gupta, rajashekar.hudumula, netdev, andrew+netdev, davem,
edumazet, kuba, pabeni
[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]
On Fri, Jan 30, 2026 at 7:10 PM ALOK TIWARI <alok.a.tiwari@oracle.com> wrote:
>
>
>
> On 1/30/2026 6:36 PM, Bhargava Chenna Marreddy wrote:
> >> On 1/30/2026 2:05 PM, Vikas Gupta wrote:
> >>>> drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> >>>> index a987afebd64d..57db3caabcfb 100644
> >>>> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> >>>> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> >>>> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
> >>>> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
> >>>> if (rc) {
> >>>> NL_SET_ERR_MSG_MOD(extack,
> >>>> - "Failed to set roce firmware version");
> >>>> + "Failed to set generic firmware version");
> >>> Thanks for fixing. I believe instead of generic, "Failed to set
> >>> firmware version" is enough.
> >> ACK. will send v2.
> > Should this be a candidate for net with a Fixes tag?
>
> I am open to either approach. It does not break functionality, but the
> current message can be misleading so I am happy to tag it for net if you
> think it’s appropriate.
I think this should go to Net with a Fixes tag, curious if others have
a different take?
Thanks,
Bhargava Marreddy
>
> >
> > Thanks,
> > Bhargava Marreddy
>
> Thanks,
> Alok
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5496 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
2026-01-30 13:40 ` ALOK TIWARI
2026-01-30 15:52 ` Bhargava Chenna Marreddy
@ 2026-01-31 1:13 ` Jakub Kicinski
1 sibling, 0 replies; 7+ messages in thread
From: Jakub Kicinski @ 2026-01-31 1:13 UTC (permalink / raw)
To: ALOK TIWARI
Cc: Bhargava Chenna Marreddy, Vikas Gupta, rajashekar.hudumula,
netdev, andrew+netdev, davem, edumazet, pabeni
On Fri, 30 Jan 2026 19:10:13 +0530 ALOK TIWARI wrote:
> >> ACK. will send v2.
> > Should this be a candidate for net with a Fixes tag?
>
> I am open to either approach. It does not break functionality, but the
> current message can be misleading so I am happy to tag it for net if you
> think it’s appropriate.
I think net-next is perfectly fine here
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-01-31 1:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-30 7:30 [PATCH net-next] bng_en: fix misleading error message for generic firmware version Alok Tiwari
2026-01-30 8:35 ` Vikas Gupta
2026-01-30 8:40 ` ALOK TIWARI
2026-01-30 13:06 ` Bhargava Chenna Marreddy
2026-01-30 13:40 ` ALOK TIWARI
2026-01-30 15:52 ` Bhargava Chenna Marreddy
2026-01-31 1:13 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox