* [PATCH v4 3/3] net/xdp: convert put_page() to put_user_page*() [not found] <20190730205705.9018-1-jhubbard@nvidia.com> @ 2019-07-30 20:57 ` john.hubbard 2019-07-31 6:08 ` Björn Töpel 0 siblings, 1 reply; 2+ messages in thread From: john.hubbard @ 2019-07-30 20:57 UTC (permalink / raw) To: Andrew Morton Cc: Al Viro, Christian Benvenuti, Christoph Hellwig, Dan Williams, Darrick J . Wong, Dave Chinner, Ira Weiny, Jan Kara, Jason Gunthorpe, Jens Axboe, Jerome Glisse, Kirill A . Shutemov, Matthew Wilcox, Michal Hocko, Mike Marciniszyn, Mike Rapoport, linux-block, linux-fsdevel, linux-mm, linux-xfs, LKML, John Hubbard, Björn Töpel, Magnus Karlsson, David S . Miller, netdev From: John Hubbard <jhubbard@nvidia.com> For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Cc: Björn Töpel <bjorn.topel@intel.com> Cc: Magnus Karlsson <magnus.karlsson@intel.com> Cc: David S. Miller <davem@davemloft.net> Cc: netdev@vger.kernel.org Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- net/xdp/xdp_umem.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c index 83de74ca729a..17c4b3d3dc34 100644 --- a/net/xdp/xdp_umem.c +++ b/net/xdp/xdp_umem.c @@ -166,14 +166,7 @@ void xdp_umem_clear_dev(struct xdp_umem *umem) static void xdp_umem_unpin_pages(struct xdp_umem *umem) { - unsigned int i; - - for (i = 0; i < umem->npgs; i++) { - struct page *page = umem->pgs[i]; - - set_page_dirty_lock(page); - put_page(page); - } + put_user_pages_dirty_lock(umem->pgs, umem->npgs, true); kfree(umem->pgs); umem->pgs = NULL; -- 2.22.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 3/3] net/xdp: convert put_page() to put_user_page*() 2019-07-30 20:57 ` [PATCH v4 3/3] net/xdp: convert put_page() to put_user_page*() john.hubbard @ 2019-07-31 6:08 ` Björn Töpel 0 siblings, 0 replies; 2+ messages in thread From: Björn Töpel @ 2019-07-31 6:08 UTC (permalink / raw) To: john.hubbard, Andrew Morton Cc: Al Viro, Christian Benvenuti, Christoph Hellwig, Dan Williams, Darrick J . Wong, Dave Chinner, Ira Weiny, Jan Kara, Jason Gunthorpe, Jens Axboe, Jerome Glisse, Kirill A . Shutemov, Matthew Wilcox, Michal Hocko, Mike Marciniszyn, Mike Rapoport, linux-block, linux-fsdevel, linux-mm, linux-xfs, LKML, John Hubbard, Magnus Karlsson, David S . Miller, netdev On 2019-07-30 22:57, john.hubbard@gmail.com wrote: > From: John Hubbard <jhubbard@nvidia.com> > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Björn Töpel <bjorn.topel@intel.com> > Cc: Magnus Karlsson <magnus.karlsson@intel.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: netdev@vger.kernel.org > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Acked-by: Björn Töpel <bjorn.topel@intel.com> > --- > net/xdp/xdp_umem.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c > index 83de74ca729a..17c4b3d3dc34 100644 > --- a/net/xdp/xdp_umem.c > +++ b/net/xdp/xdp_umem.c > @@ -166,14 +166,7 @@ void xdp_umem_clear_dev(struct xdp_umem *umem) > > static void xdp_umem_unpin_pages(struct xdp_umem *umem) > { > - unsigned int i; > - > - for (i = 0; i < umem->npgs; i++) { > - struct page *page = umem->pgs[i]; > - > - set_page_dirty_lock(page); > - put_page(page); > - } > + put_user_pages_dirty_lock(umem->pgs, umem->npgs, true); > > kfree(umem->pgs); > umem->pgs = NULL; > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-31 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190730205705.9018-1-jhubbard@nvidia.com>
2019-07-30 20:57 ` [PATCH v4 3/3] net/xdp: convert put_page() to put_user_page*() john.hubbard
2019-07-31 6:08 ` Björn Töpel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).