From: David Ahern <dsahern@gmail.com>
To: Wojciech Drewek <wojciech.drewek@intel.com>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next v5 1/2] ip: GTP support in ip link
Date: Wed, 16 Mar 2022 18:56:42 -0600 [thread overview]
Message-ID: <c1cb87c2-0107-7b0d-966f-b26f44b23d80@gmail.com> (raw)
In-Reply-To: <20220316110815.46779-2-wojciech.drewek@intel.com>
On 3/16/22 5:08 AM, Wojciech Drewek wrote:
> +static void gtp_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
> +{
> +
> + if (tb[IFLA_GTP_ROLE]) {
> + __u32 role = rta_getattr_u32(tb[IFLA_GTP_ROLE]);
> +
> + print_string(PRINT_ANY, "role", "role %s ",
> + role == GTP_ROLE_SGSN ? "sgsn" : "ggsn");
> + }
as a u32 does that mean more roles might get added? Seems like this
should have a attr to string converter that handles future additions.
next prev parent reply other threads:[~2022-03-17 0:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 11:08 [PATCH iproute2-next v5 0/2] GTP support for ip link and tc flowers Wojciech Drewek
2022-03-16 11:08 ` [PATCH iproute2-next v5 1/2] ip: GTP support in ip link Wojciech Drewek
2022-03-17 0:56 ` David Ahern [this message]
2022-03-17 11:11 ` Drewek, Wojciech
2022-03-17 14:02 ` Harald Welte
2022-03-17 14:47 ` David Ahern
2022-03-17 16:11 ` Drewek, Wojciech
2022-03-16 11:08 ` [PATCH iproute2-next v5 2/2] f_flower: Implement gtp options support Wojciech Drewek
2022-03-17 0:58 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1cb87c2-0107-7b0d-966f-b26f44b23d80@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).