netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility
@ 2018-03-25  6:38 Leon Romanovsky
  2018-03-25 13:52 ` Steve Wise
  2018-03-26 14:03 ` David Ahern
  0 siblings, 2 replies; 5+ messages in thread
From: Leon Romanovsky @ 2018-03-25  6:38 UTC (permalink / raw)
  To: David Ahern
  Cc: Leon Romanovsky, netdev, RDMA mailing list, Stephen Hemminger,
	Steve Wise

From: Leon Romanovsky <leonro@mellanox.com>

In iproute2 package, the updates of UAPIs files are performed
after the needed feature lands in kernel's net-next tree.

Such development flow created delays to the rdma tool developers,
who uses rdma-next tree as a basis for their work.

Move RDMA UAPI file to be under rdma/ folder, so whole responsibility
of syncing this file will be on them.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 rdma/Makefile                                      | 1 +
 {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
 2 files changed, 1 insertion(+)
 rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)

diff --git a/rdma/Makefile b/rdma/Makefile
index 360f09b2..819fcbe3 100644
--- a/rdma/Makefile
+++ b/rdma/Makefile
@@ -4,6 +4,7 @@ include ../config.mk
 TARGETS :=

 ifeq ($(HAVE_MNL),y)
+CFLAGS += -I./include/uapi/

 RDMA_OBJ = rdma.o utils.o dev.o link.o res.o

diff --git a/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h
similarity index 100%
rename from include/uapi/rdma/rdma_netlink.h
rename to rdma/include/uapi/rdma/rdma_netlink.h

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility
  2018-03-25  6:38 [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility Leon Romanovsky
@ 2018-03-25 13:52 ` Steve Wise
  2018-03-26 14:03 ` David Ahern
  1 sibling, 0 replies; 5+ messages in thread
From: Steve Wise @ 2018-03-25 13:52 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'

> Subject: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be
> under RDMA responsibility
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> In iproute2 package, the updates of UAPIs files are performed
> after the needed feature lands in kernel's net-next tree.
> 
> Such development flow created delays to the rdma tool developers,
> who uses rdma-next tree as a basis for their work.
> 
> Move RDMA UAPI file to be under rdma/ folder, so whole responsibility
> of syncing this file will be on them.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

Reviewed-by: Steve Wise <swise@opengridcomputing.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility
  2018-03-25  6:38 [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility Leon Romanovsky
  2018-03-25 13:52 ` Steve Wise
@ 2018-03-26 14:03 ` David Ahern
  2018-03-26 14:23   ` Steve Wise
  1 sibling, 1 reply; 5+ messages in thread
From: David Ahern @ 2018-03-26 14:03 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: Leon Romanovsky, netdev, RDMA mailing list, Stephen Hemminger,
	Steve Wise

On 3/25/18 12:38 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> In iproute2 package, the updates of UAPIs files are performed
> after the needed feature lands in kernel's net-next tree.
> 
> Such development flow created delays to the rdma tool developers,
> who uses rdma-next tree as a basis for their work.
> 
> Move RDMA UAPI file to be under rdma/ folder, so whole responsibility
> of syncing this file will be on them.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/Makefile                                      | 1 +
>  {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
>  2 files changed, 1 insertion(+)
>  rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)

applied to iproute2-next

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility
  2018-03-26 14:03 ` David Ahern
@ 2018-03-26 14:23   ` Steve Wise
  2018-03-26 17:07     ` Leon Romanovsky
  0 siblings, 1 reply; 5+ messages in thread
From: Steve Wise @ 2018-03-26 14:23 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: David Ahern, Leon Romanovsky, netdev, RDMA mailing list,
	Stephen Hemminger



On 3/26/2018 9:03 AM, David Ahern wrote:
> On 3/25/18 12:38 AM, Leon Romanovsky wrote:
>> From: Leon Romanovsky <leonro@mellanox.com>
>>
>> In iproute2 package, the updates of UAPIs files are performed
>> after the needed feature lands in kernel's net-next tree.
>>
>> Such development flow created delays to the rdma tool developers,
>> who uses rdma-next tree as a basis for their work.
>>
>> Move RDMA UAPI file to be under rdma/ folder, so whole responsibility
>> of syncing this file will be on them.
>>
>> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
>> ---
>>  rdma/Makefile                                      | 1 +
>>  {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
>>  2 files changed, 1 insertion(+)
>>  rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)
> applied to iproute2-next
>

Hey Leon, so how do I change rdma/include/uapi/rdma_netlink.h now for my
series [1]?  Do I just make the changes?  Or is there some other process?

[1] https://www.spinics.net/lists/linux-rdma/msg61419.html

Steve.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility
  2018-03-26 14:23   ` Steve Wise
@ 2018-03-26 17:07     ` Leon Romanovsky
  0 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2018-03-26 17:07 UTC (permalink / raw)
  To: Steve Wise; +Cc: David Ahern, netdev, RDMA mailing list, Stephen Hemminger

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

On Mon, Mar 26, 2018 at 09:23:46AM -0500, Steve Wise wrote:
>
>
> On 3/26/2018 9:03 AM, David Ahern wrote:
> > On 3/25/18 12:38 AM, Leon Romanovsky wrote:
> >> From: Leon Romanovsky <leonro@mellanox.com>
> >>
> >> In iproute2 package, the updates of UAPIs files are performed
> >> after the needed feature lands in kernel's net-next tree.
> >>
> >> Such development flow created delays to the rdma tool developers,
> >> who uses rdma-next tree as a basis for their work.
> >>
> >> Move RDMA UAPI file to be under rdma/ folder, so whole responsibility
> >> of syncing this file will be on them.
> >>
> >> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> >> ---
> >>  rdma/Makefile                                      | 1 +
> >>  {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
> >>  2 files changed, 1 insertion(+)
> >>  rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)
> > applied to iproute2-next
> >
>
> Hey Leon, so how do I change rdma/include/uapi/rdma_netlink.h now for my
> series [1]?  Do I just make the changes?  Or is there some other process?

I don't think that we need "process" yet, simply copy from kernel.

>
> [1] https://www.spinics.net/lists/linux-rdma/msg61419.html
>
> Steve.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-03-26 17:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-25  6:38 [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility Leon Romanovsky
2018-03-25 13:52 ` Steve Wise
2018-03-26 14:03 ` David Ahern
2018-03-26 14:23   ` Steve Wise
2018-03-26 17:07     ` Leon Romanovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).