From: Randy Dunlap <rdunlap@infradead.org>
To: Amy Parker <enbyamy@gmail.com>,
davem@davemloft.net, kuba@kernel.org, akpm@linux-foundation.org,
rppt@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide
Date: Fri, 5 Feb 2021 19:16:44 -0800 [thread overview]
Message-ID: <c1eae547-aa14-8307-cb81-b585a13bbd3d@infradead.org> (raw)
In-Reply-To: <20210206000146.616465-1-enbyamy@gmail.com>
On 2/5/21 4:01 PM, Amy Parker wrote:
> This patchset updates atarilance.c and sun3lance.c to follow the kernel
> style guide. Each patch tackles a different issue in the style guide.
>
> -Amy IP
>
> Amy Parker (3):
> drivers/net/ethernet/amd: Correct spacing around C keywords
> drivers/net/ethernet/amd: Fix bracket matching and line levels
> drivers/net/ethernet/amd: Break apart one-lined expressions
>
> drivers/net/ethernet/amd/atarilance.c | 64 ++++++++++++++-------------
> drivers/net/ethernet/amd/sun3lance.c | 64 +++++++++++++++------------
> 2 files changed, 69 insertions(+), 59 deletions(-)
>
Hi Amy,
For each patch, can you confirm that the before & after binary files
are the same? or if they are not the same, explain why not?
Just something that I have done in the past...
thanks.
--
~Randy
next prev parent reply other threads:[~2021-02-06 3:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 0:01 [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide Amy Parker
2021-02-06 0:01 ` [PATCH 1/3] drivers/net/ethernet/amd: Correct spacing around C keywords Amy Parker
2021-02-06 0:01 ` [PATCH 2/3] drivers/net/ethernet/amd: Fix bracket matching and line levels Amy Parker
2021-02-06 0:01 ` [PATCH 3/3] drivers/net/ethernet/amd: Break apart one-lined expressions Amy Parker
2021-02-06 3:16 ` Randy Dunlap [this message]
2021-02-06 4:28 ` [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide Amy Parker
2021-02-06 20:07 ` Jakub Kicinski
2021-02-07 20:48 ` Amy Parker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1eae547-aa14-8307-cb81-b585a13bbd3d@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=enbyamy@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).