From: Paolo Abeni <pabeni@redhat.com>
To: Lucas Karpinski <lkarpins@redhat.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests/net: synchronize udpgso_bench rx and tx
Date: Tue, 31 Oct 2023 15:49:45 +0100 [thread overview]
Message-ID: <c1f3236d0a2a2f540f65815633e709accdbc197a.camel@redhat.com> (raw)
In-Reply-To: <vzz3qfbfq52qja24y25lopif27sdwyvz3jmmcbx5wm6jc5l53b@fy7ym6xk4zsb>
On Tue, 2023-10-31 at 09:26 -0400, Lucas Karpinski wrote:
> > Since you wrote the same function verbatim in 3 different files, I
> > think it would be better place it in separate, new, net_helper.sh
> > file
> > and include such file from the various callers. Possibly
> > additionally
> > rename the function as wait_local_udp_port_listen.
> >
> Thanks, I'll move it over. I think it would be best though to leave
> udp out of the name and to just pass the protocol as an argument.
Indeed. I suggested the other option just to keep it the simpler, but
if you have time and will, please go ahead!
Cheers,
Paolo
next prev parent reply other threads:[~2023-10-31 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 17:40 [PATCH v2] selftests/net: synchronize udpgso_bench rx and tx Lucas Karpinski
2023-10-31 9:18 ` Paolo Abeni
2023-10-31 13:26 ` Lucas Karpinski
2023-10-31 14:49 ` Paolo Abeni [this message]
2023-10-31 9:22 ` Paolo Abeni
2023-10-31 21:11 ` Willem de Bruijn
2023-11-01 13:17 ` Lucas Karpinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1f3236d0a2a2f540f65815633e709accdbc197a.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkarpins@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox