From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36607C43381 for ; Fri, 15 Mar 2019 08:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0021D218A5 for ; Fri, 15 Mar 2019 08:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="Lnz4W1yw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728594AbfCOIp4 (ORCPT ); Fri, 15 Mar 2019 04:45:56 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:33989 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727291AbfCOIp4 (ORCPT ); Fri, 15 Mar 2019 04:45:56 -0400 Received: by mail-lf1-f68.google.com with SMTP id y18so6299973lfe.1 for ; Fri, 15 Mar 2019 01:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CgIwiuBReUp7FO75vm5g2xVt+pgi2tjdOv+S4xOIdcA=; b=Lnz4W1ywCTs75Y5tNUf7wuVeAjm1RIwVTD0w+mU6m1EXYpDh8gIxnZ/7Jt8QSNunp2 WfCwrMuIvt7SBlSUCKGzNWLpUhBchKSr2Zcfo0fRXugIbo5xL0I8dx+kl+v/IYPoDvnc Yvmo5AObqxMPfOWHKJqYEnRVxOnes7tBbwK0uMQgcI9ygY9FTikk+j0SLojsiRUDRSzW a5yJsD+ud81T1+Nazpy2UM7TOxfMI1kvwJNlDEYkMDCblFdwm3xMYlaLlGdCe/4Zp5s8 7o0hsqMwQssCmtyjoZG+2fmKteVePuyeHts7Czt3mxEOnr9hlZTjGhhrMhNxO0h5heXd xYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CgIwiuBReUp7FO75vm5g2xVt+pgi2tjdOv+S4xOIdcA=; b=eFCpylAl1sG1/xfiIMzoCwMpweepW0CLTcZNXkyUUIlYgGYt6oXm1CzK4mNrRN4uWH DmfR0ypidu76v8K803CnRqhaUPCxOZSS8fZIc4egJPwyb9M8p21tOSaHFCT6eM3fwUNX dETLwQWo0Y1jkuc9ASwu4Q21adoItD9VMcNnSIR7OCL0tHA/N3pez71V3IasgpjFCHWQ UlCHoJOLetZTCYuHo3dvZ2/WyBWAW8OeklQaTpyYnJdQNFICLGtDNzAqkErGvYGVo0Zr jPsj8lNEj15degQGPrWPq6lGXze9BFwcIwzQRly4UkJALM5K9g0ijFOOUXQI+KTAb6fn varw== X-Gm-Message-State: APjAAAXb8k5st9oCXjwl5J+jaSZjzabwP7bEof6xaI5HGZu4mWwZ7tnu VbtSPp9SQyyFXV2KlriME/G5cw== X-Google-Smtp-Source: APXvYqwCSQQOf9uOpfetuKgSIxOyQJlDx2hOOiZYhN45hVZWoTahL0kxDL5twk4GkpZUgJJNxUtrkQ== X-Received: by 2002:ac2:4474:: with SMTP id y20mr1557805lfl.42.1552639554170; Fri, 15 Mar 2019 01:45:54 -0700 (PDT) Received: from [192.168.0.199] ([31.173.80.66]) by smtp.gmail.com with ESMTPSA id k5sm282123lja.78.2019.03.15.01.45.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 01:45:53 -0700 (PDT) Subject: Re: [PATCH 1/2] net: stmmac: don't set own bit too early for jumbo frames To: Aaro Koskinen , "David S. Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Thor Thayer , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Aaro Koskinen References: <20190314194320.25566-1-aaro.koskinen@iki.fi> From: Sergei Shtylyov Message-ID: Date: Fri, 15 Mar 2019 11:45:40 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190314194320.25566-1-aaro.koskinen@iki.fi> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 14.03.2019 22:43, Aaro Koskinen wrote: > From: Aaro Koskinen > > Commit 0e80bdc9a72d ("stmmac: first frame prep at the end of xmit > routine") overlooked jumbo frames when re-ordering the code, and as a > result the own bit was not getting set anymore for the first jumbo frame > descriptor. Commit 487e2e22ab79 ("net: stmmac: Set OWN bit for jumbo > frames") tried to fix this, but now the bit is getting set too early and > the DMA may start while we are still setting up the remaing descriptors. Remaining? > And with the chain mode the own bit remains still unset. > > Fix by setting the own bit at the end of xmit also with jumbo frames. > > Fixes: 0e80bdc9a72d ("stmmac: first frame prep at the end of xmit routine") > Fixes: 487e2e22ab79 ("net: stmmac: Set OWN bit for jumbo frames") > Signed-off-by: Aaro Koskinen [...] MBR, Sergei