From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Forrest Fleming <ffleming@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: intel: Cleanup e1000 - add space between }}
Date: Mon, 26 Aug 2019 01:03:33 -0700 [thread overview]
Message-ID: <c2279a78904b581924894b712403299903eacbfc.camel@intel.com> (raw)
In-Reply-To: <20190823191421.3318-1-ffleming@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Fri, 2019-08-23 at 19:14 +0000, Forrest Fleming wrote:
> suggested by checkpatch
>
> Signed-off-by: Forrest Fleming <ffleming@gmail.com>
> ---
> .../net/ethernet/intel/e1000/e1000_param.c | 28 +++++++++----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
While I do not see an issue with this change, I wonder how important it is
to make such a change. Especially since most of the hardware supported by
this driver is not available for testing. In addition, this is one
suggested change by checkpatch.pl that I personally do not agree with.
This is not a hard NAK, but you have to explain how this change makes the
code more readable before I consider it.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-26 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 19:14 [PATCH] net: intel: Cleanup e1000 - add space between }} Forrest Fleming
2019-08-26 8:03 ` Jeff Kirsher [this message]
2019-08-27 3:41 ` Joe Perches
2019-08-27 19:02 ` Jeff Kirsher
2019-08-27 19:07 ` Joe Perches
2019-08-27 19:45 ` Forrest Fleming
2019-08-27 20:27 ` Jeff Kirsher
2019-08-27 20:27 ` Jeff Kirsher
2019-08-27 20:49 ` [PATCH] checkpatch: Allow consecutive close braces Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2279a78904b581924894b712403299903eacbfc.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=ffleming@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).