Re: [PATCH net-next v4 1/3] net/smc: clear the correct v2 slot and buffer in smc_wr_tx_put_slot()

[Mahanta Jambigi <mjambigi@linux.ibm.com>]

On 16/07/26 5:07 pm, D. Wythe wrote:
> smc_wr_tx_put_slot() tries to reset the v2 pending slot and buffer with
> memset(&link->wr_tx_v2_pend, 0, sizeof(link->wr_tx_v2_pend)) and the
> equivalent for wr_tx_buf_v2. Both are pointers, so this zeroes the 8-byte
> pointer variable instead of the structure it points to. The pending slot
> and buffer are therefore never actually cleared, and the pointers get
> overwritten with NULL.
> 
> Pass the pointers directly and use sizeof(*pointer) so the intended
> structures are cleared.
> 
> Fixes: 8799e310fb3f ("net/smc: add v2 support to the work request layer")
> Signed-off-by: D. Wythe <alibuda@linux.alibaba.com>
> Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
> ---
>  net/smc/smc_wr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/smc/smc_wr.c b/net/smc/smc_wr.c
> index 59c92b46945c..6b5add922993 100644
> --- a/net/smc/smc_wr.c
> +++ b/net/smc/smc_wr.c
> @@ -288,10 +288,10 @@ int smc_wr_tx_put_slot(struct smc_link *link,
>  	} else if (link->lgr->smc_version == SMC_V2 &&
>  		   pend->idx == link->wr_tx_cnt) {
>  		/* Large v2 buffer */
> -		memset(&link->wr_tx_v2_pend, 0,
> -		       sizeof(link->wr_tx_v2_pend));
> -		memset(&link->lgr->wr_tx_buf_v2, 0,
> -		       sizeof(link->lgr->wr_tx_buf_v2));
> +		memset(link->wr_tx_v2_pend, 0,
> +		       sizeof(*link->wr_tx_v2_pend));
> +		memset(link->lgr->wr_tx_buf_v2, 0,
> +		       sizeof(*link->lgr->wr_tx_buf_v2));
>  		return 1;
>  	}
>  

Reviewed-by: Mahanta Jambigi <mjambigi@linux.ibm.com>