netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Oleksandr Mazur <oleksandr.mazur@plvision.eu>, netdev@vger.kernel.org
Cc: jiri@nvidia.com, davem@davemloft.net,
	linux-kernel@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH iproute2-next V3] devlink: add support for port params get/set
Date: Mon, 8 Feb 2021 08:41:43 -0700	[thread overview]
Message-ID: <c22aaccf-59a9-d3bc-8eb3-0496f17c8dc3@gmail.com> (raw)
In-Reply-To: <20210202130445.5950-1-oleksandr.mazur@plvision.eu>

On 2/2/21 6:04 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
> 
> Example:
> $ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value false cmode runtime
> 
> $ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter
> netdevsim/netdevsim0/0:
>   name test_port_parameter type driver-specific
>     values:
>       cmode runtime value false
> 
> $ devlink port  -jp param show netdevsim/netdevsim0/0 name test_port_parameter
> {
>     "param": {
>         "netdevsim/netdevsim0/0": [ {
>                 "name": "test_port_parameter",
>                 "type": "driver-specific",
>                 "values": [ {
>                         "cmode": "runtime",
>                         "value": false
>                     } ]
>             } ]
>     }
> }
> 
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
> ---
> V3:
>     1) Add usage example;
>     2) Remove stray newline in code;
> V2:
>     1) Add bash completion for port param;
>     2) Add man decsription / examples for port param;
> 
>  bash-completion/devlink |  55 ++++++++
>  devlink/devlink.c       | 274 +++++++++++++++++++++++++++++++++++++++-
>  man/man8/devlink-port.8 |  65 ++++++++++
>  3 files changed, 388 insertions(+), 6 deletions(-)
> 

does not apply to iproute2-next. please rebase


      parent reply	other threads:[~2021-02-08 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 13:04 [PATCH iproute2-next V3] devlink: add support for port params get/set Oleksandr Mazur
2021-02-05  4:38 ` David Ahern
2021-02-05 12:04 ` Jiri Pirko
2021-02-08 15:41 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c22aaccf-59a9-d3bc-8eb3-0496f17c8dc3@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr.mazur@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).