From: David Ahern <dsahern@gmail.com>
To: Tommi Rantala <tommi.t.rantala@nokia.com>, netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
Alexey Kodanev <alexey.kodanev@oracle.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst
Date: Mon, 5 Feb 2018 16:20:49 -0700 [thread overview]
Message-ID: <c242ed66-cc0c-0783-360a-88e73fe5d541@gmail.com> (raw)
In-Reply-To: <20180205194814.14006-1-tommi.t.rantala@nokia.com>
On 2/5/18 12:48 PM, Tommi Rantala wrote:
> Fix dst reference count leak in sctp_v4_get_dst() introduced in commit
> 410f03831 ("sctp: add routing output fallback"):
>
> When walking the address_list, successive ip_route_output_key() calls
> may return the same rt->dst with the reference incremented on each call.
>
> The code would not decrement the dst refcount when the dst pointer was
> identical from the previous iteration, causing the dst refcnt leak.
>
...
> ...
>
> Fixes: 410f03831 ("sctp: add routing output fallback")
> Fixes: 0ca50d12f ("sctp: fix src address selection if using secondary addresses")
any syzbot references for this bug?
next prev parent reply other threads:[~2018-02-05 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 19:48 [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst Tommi Rantala
2018-02-05 22:07 ` Marcelo Ricardo Leitner
2018-02-05 23:20 ` David Ahern [this message]
2018-02-06 5:06 ` Xin Long
2018-02-06 8:27 ` Dmitry Vyukov
2018-02-06 1:17 ` Neil Horman
2018-02-06 2:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c242ed66-cc0c-0783-360a-88e73fe5d541@gmail.com \
--to=dsahern@gmail.com \
--cc=alexey.kodanev@oracle.com \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tommi.t.rantala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).