Re: [PATCH net-next v02 2/6] hinic3: Add PF management interfaces

[Paolo Abeni <pabeni@redhat.com>]

On 10/17/25 10:30 AM, Fan Gong wrote:
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h
> index 78cface6ddd7..58c0c0b55097 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h
> @@ -39,24 +39,25 @@ struct hinic3_pcidev {
>  };
>  
>  struct hinic3_hwdev {
> -	struct hinic3_pcidev        *adapter;
> -	struct pci_dev              *pdev;
> -	struct device               *dev;
> -	int                         dev_id;
> -	struct hinic3_hwif          *hwif;
> -	struct hinic3_cfg_mgmt_info *cfg_mgmt;
> -	struct hinic3_aeqs          *aeqs;
> -	struct hinic3_ceqs          *ceqs;
> -	struct hinic3_mbox          *mbox;
> -	struct hinic3_cmdqs         *cmdqs;
> -	struct delayed_work         sync_time_task;
> -	struct workqueue_struct     *workq;
> -	/* protect channel init and uninit */
> -	spinlock_t                  channel_lock;
> -	u64                         features[COMM_MAX_FEATURE_QWORD];
> -	u32                         wq_page_size;
> -	u8                          max_cmdq;
> -	ulong                       func_state;
> +	struct hinic3_pcidev         *adapter;
> +	struct pci_dev               *pdev;
> +	struct device                *dev;
> +	int                          dev_id;
> +	struct hinic3_hwif           *hwif;
> +	struct hinic3_cfg_mgmt_info  *cfg_mgmt;
> +	struct hinic3_aeqs           *aeqs;
> +	struct hinic3_ceqs           *ceqs;
> +	struct hinic3_mbox           *mbox;
> +	struct hinic3_msg_pf_to_mgmt *pf_to_mgmt;
> +	struct hinic3_cmdqs          *cmdqs;
> +	struct delayed_work          sync_time_task;
> +	struct workqueue_struct      *workq;
> +	/* protect hwdev channel init and uninit */
> +	spinlock_t                   channel_lock;
> +	u64                          features[COMM_MAX_FEATURE_QWORD];
> +	u32                          wq_page_size;
> +	u8                           max_cmdq;
> +	ulong                        func_state;

The above is a nice way to hide a single line addition. Please either
avoid the reformatting entirely (preferred) or do the re-indentation in
a separate pre-req patch.

/P