From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [Patch net v2] net/ipv6: do not copy dst flags on rt init Date: Mon, 17 Sep 2018 10:27:08 -0700 Message-ID: References: <20180917172053.126170-1-posk@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Peter Oskolkov , David Miller , netdev@vger.kernel.org Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:40213 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbeIQWz3 (ORCPT ); Mon, 17 Sep 2018 18:55:29 -0400 Received: by mail-pf1-f193.google.com with SMTP id s13-v6so7877298pfi.7 for ; Mon, 17 Sep 2018 10:27:10 -0700 (PDT) In-Reply-To: <20180917172053.126170-1-posk@google.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/17/18 10:20 AM, Peter Oskolkov wrote: > DST_NOCOUNT in dst_entry::flags tracks whether the entry counts > toward route cache size (net->ipv6.sysctl.ip6_rt_max_size). > > If the flag is NOT set, dst_ops::pcpuc_entries counter is incremented > in dist_init() and decremented in dst_destroy(). > > This flag is tied to allocation/deallocation of dst_entry and > should not be copied from another dst/route. Otherwise it can happen > that dst_ops::pcpuc_entries counter grows until no new routes can > be allocated because the counter reached ip6_rt_max_size due to > DST_NOCOUNT not set and thus no counter decrements on gc-ed routes. > > Fixes: 3b6761d18bc1 ("net/ipv6: Move dst flags to booleans in fib entries") > Cc: David Ahern > Acked-by: Wei Wang > Signed-off-by: Peter Oskolkov > --- > net/ipv6/route.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 3eed045c65a5..480a79f47c52 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -946,8 +946,6 @@ static void ip6_rt_init_dst_reject(struct rt6_info *rt, struct fib6_info *ort) > > static void ip6_rt_init_dst(struct rt6_info *rt, struct fib6_info *ort) > { > - rt->dst.flags |= fib6_info_dst_flags(ort); > - > if (ort->fib6_flags & RTF_REJECT) { > ip6_rt_init_dst_reject(rt, ort); > return; > Reviewed-by: David Ahern Thanks for the patch.