Netdev List
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Tomasz Lichwala <tomasz.lichwala@linux.intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iwl-next] ixgbe: implement Total Port Shutdown for E610
Date: Wed, 12 Aug 2026 06:21:15 +0200	[thread overview]
Message-ID: <c282feb2-b9aa-40b9-828e-055586c4c2a8@intel.com> (raw)
In-Reply-To: <20260810075652.27915-1-tomasz.lichwala@linux.intel.com>

On 8/10/26 09:56, Tomasz Lichwala wrote:
> Implement Total Port Shutdown (TPS) for E610. When TPS is provisioned
> in the NVM (by the platform firmware), the port's PHY is powered down
> whenever the interface is administratively down.
> 
> When the PORT_DIS bit is set in the Link Default Override TLV in
> the NVM PFA area, enable Total Port Shutdown (TPS). This forces the
> link-down-on-close private flag and prevents the user from changing
> it via ethtool, ensuring the PHY is powered down when the interface
> is brought down as provisioned in the NVM.
> 
> The Link Default Override TLV (0x134) is read from the NVM PFA during
> driver init. Each port has its own 10-word configuration block within
> the TLV. If the PORT_DIS bit is set in the port's link_options field,
> the driver sets both TOTAL_PORT_SHUTDOWN_ENA and LINK_DOWN_ON_CLOSE
> flags.
> 
> Signed-off-by: Tomasz Lichwala <tomasz.lichwala@linux.intel.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 +
>   drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 38 +++++++++++++++++++
>   drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h |  2 +
>   .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  | 13 +++++++
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14 ++++++-
>   .../ethernet/intel/ixgbe/ixgbe_type_e610.h    | 13 +++++++
>   6 files changed, 80 insertions(+), 1 deletion(-)

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

---
Sashiko failed to apply, likely because it assumes base as
"net-next/main" instead of "tony/dev-queue", and the former has no yet
a dependency from Jedrzej.

I'm sure you have checked it against our local Sashiko and it was fine,
although the model used was different.

      reply	other threads:[~2026-08-12  4:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  7:56 [iwl-next] ixgbe: implement Total Port Shutdown for E610 Tomasz Lichwala
2026-08-12  4:21 ` Przemek Kitszel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c282feb2-b9aa-40b9-828e-055586c4c2a8@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=tomasz.lichwala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox