From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jon Maxwell <jmaxwell37@gmail.com>, davem@davemloft.net
Cc: edumazet@google.com, ncardwell@google.com,
David.Laight@aculab.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jmaxwell@redhat.com
Subject: Re: [net-next,v3] tcp: Improve setsockopt() TCP_USER_TIMEOUT accuracy
Date: Tue, 10 Jul 2018 05:48:22 -0700 [thread overview]
Message-ID: <c29f1535-3c5d-e588-862c-ba948363c973@gmail.com> (raw)
In-Reply-To: <3f856638-52bc-6630-a3d2-2b50f1bf7e48@gmail.com>
On 07/10/2018 05:38 AM, Eric Dumazet wrote:
> Note that if we always do jiffies_to_msecs(icsk->icsk_user_timeout) in TCP,
> we also could change the convention and store msecs in this field instead of jiffies.
>
> That would eliminate the msecs_to_jiffies() and jiffies_to_msecs() dance.
>
> (That would be done in a patch of its own, of course)
tcp_keepalive_timer() does use icsk->icsk_user_timeout directly in jiffies unit,
but considering keeapalive timers are rarely used, this point would have to
do the msecs_to_jiffies() conversion.
next prev parent reply other threads:[~2018-07-10 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 6:51 [net-next,v3] tcp: Improve setsockopt() TCP_USER_TIMEOUT accuracy Jon Maxwell
2018-07-10 9:17 ` David Laight
2018-07-10 12:38 ` Eric Dumazet
2018-07-10 12:48 ` Eric Dumazet [this message]
2018-07-11 0:33 ` Jonathan Maxwell
2018-07-11 2:04 ` Eric Dumazet
2018-07-11 2:34 ` Jonathan Maxwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c29f1535-3c5d-e588-862c-ba948363c973@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaxwell37@gmail.com \
--cc=jmaxwell@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).