From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Russell King <rmk+kernel@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 2/5] ethtool: add basic handling of struct ethtool_keee
Date: Mon, 1 Jan 2024 22:24:36 +0100 [thread overview]
Message-ID: <c2a3aa5c-0c12-4aaf-8a44-05f015e718bd@gmail.com> (raw)
In-Reply-To: <783d4a61-2f08-41fc-b91d-bd5f512586a2@gmail.com>
This is in preparation of follow-up functional changes, and it adds
basic handling of struct ethtool_keee. No functional change intended.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
net/ethtool/eee.c | 29 ++++++++++++++++++-----------
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/net/ethtool/eee.c b/net/ethtool/eee.c
index 2853394d0..9b34d3310 100644
--- a/net/ethtool/eee.c
+++ b/net/ethtool/eee.c
@@ -13,7 +13,7 @@ struct eee_req_info {
struct eee_reply_data {
struct ethnl_reply_data base;
- struct ethtool_eee eee;
+ struct ethtool_keee keee;
};
#define EEE_REPDATA(__reply_base) \
@@ -30,14 +30,17 @@ static int eee_prepare_data(const struct ethnl_req_info *req_base,
{
struct eee_reply_data *data = EEE_REPDATA(reply_base);
struct net_device *dev = reply_base->dev;
+ struct ethtool_keee *keee = &data->keee;
+ struct ethtool_eee *eee = &keee->eee;
int ret;
+ eee->is_member_of_keee = 1;
if (!dev->ethtool_ops->get_eee)
return -EOPNOTSUPP;
ret = ethnl_ops_begin(dev);
if (ret < 0)
return ret;
- ret = dev->ethtool_ops->get_eee(dev, &data->eee);
+ ret = dev->ethtool_ops->get_eee(dev, eee);
ethnl_ops_complete(dev);
return ret;
@@ -48,7 +51,8 @@ static int eee_reply_size(const struct ethnl_req_info *req_base,
{
bool compact = req_base->flags & ETHTOOL_FLAG_COMPACT_BITSETS;
const struct eee_reply_data *data = EEE_REPDATA(reply_base);
- const struct ethtool_eee *eee = &data->eee;
+ const struct ethtool_keee *keee = &data->keee;
+ const struct ethtool_eee *eee = &keee->eee;
int len = 0;
int ret;
@@ -84,7 +88,8 @@ static int eee_fill_reply(struct sk_buff *skb,
{
bool compact = req_base->flags & ETHTOOL_FLAG_COMPACT_BITSETS;
const struct eee_reply_data *data = EEE_REPDATA(reply_base);
- const struct ethtool_eee *eee = &data->eee;
+ const struct ethtool_keee *keee = &data->keee;
+ const struct ethtool_eee *eee = &keee->eee;
int ret;
ret = ethnl_put_bitset32(skb, ETHTOOL_A_EEE_MODES_OURS,
@@ -132,28 +137,30 @@ ethnl_set_eee(struct ethnl_req_info *req_info, struct genl_info *info)
{
struct net_device *dev = req_info->dev;
struct nlattr **tb = info->attrs;
- struct ethtool_eee eee = {};
+ struct ethtool_keee keee = {};
+ struct ethtool_eee *eee = &keee.eee;
bool mod = false;
int ret;
- ret = dev->ethtool_ops->get_eee(dev, &eee);
+ eee->is_member_of_keee = 1;
+ ret = dev->ethtool_ops->get_eee(dev, eee);
if (ret < 0)
return ret;
- ret = ethnl_update_bitset32(&eee.advertised, EEE_MODES_COUNT,
+ ret = ethnl_update_bitset32(&eee->advertised, EEE_MODES_COUNT,
tb[ETHTOOL_A_EEE_MODES_OURS],
link_mode_names, info->extack, &mod);
if (ret < 0)
return ret;
- ethnl_update_bool32(&eee.eee_enabled, tb[ETHTOOL_A_EEE_ENABLED], &mod);
- ethnl_update_bool32(&eee.tx_lpi_enabled,
+ ethnl_update_bool32(&eee->eee_enabled, tb[ETHTOOL_A_EEE_ENABLED], &mod);
+ ethnl_update_bool32(&eee->tx_lpi_enabled,
tb[ETHTOOL_A_EEE_TX_LPI_ENABLED], &mod);
- ethnl_update_u32(&eee.tx_lpi_timer, tb[ETHTOOL_A_EEE_TX_LPI_TIMER],
+ ethnl_update_u32(&eee->tx_lpi_timer, tb[ETHTOOL_A_EEE_TX_LPI_TIMER],
&mod);
if (!mod)
return 0;
- ret = dev->ethtool_ops->set_eee(dev, &eee);
+ ret = dev->ethtool_ops->set_eee(dev, eee);
return ret < 0 ? ret : 1;
}
--
2.43.0
next prev parent reply other threads:[~2024-01-01 21:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 21:22 [PATCH net-next 0/5] ethtool: add support for EEE linkmodes beyond bit 32 Heiner Kallweit
2024-01-01 21:23 ` [PATCH net-next 1/5] ethtool: add struct ethtool_keee and extend struct ethtool_eee Heiner Kallweit
2024-01-04 16:27 ` Marek Behún
2024-01-04 16:46 ` Heiner Kallweit
2024-01-04 17:16 ` Andrew Lunn
2024-01-04 20:30 ` Heiner Kallweit
2024-01-05 22:35 ` Heiner Kallweit
2024-01-05 23:15 ` Andrew Lunn
2024-01-08 15:38 ` Russell King (Oracle)
2024-01-01 21:24 ` Heiner Kallweit [this message]
2024-01-01 21:25 ` [PATCH net-next 3/5] ethtool: send EEE linkmode bitmaps to userspace Heiner Kallweit
2024-01-01 21:26 ` [PATCH net-next 4/5] net: phy: c45: prepare genphy_c45_ethtool_set_eee for follow-up extension Heiner Kallweit
2024-01-01 21:28 ` [PATCH net-next 5/5] net: phy: c45: extend genphy_c45_ethtool_[set|get]_eee Heiner Kallweit
2024-01-06 19:44 ` [PATCH net-next 0/5] ethtool: add support for EEE linkmodes beyond bit 32 Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2a3aa5c-0c12-4aaf-8a44-05f015e718bd@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).