From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances Date: Sat, 6 Jan 2018 12:29:03 -0700 Message-ID: References: <20180105230929.5645-1-jiri@resnulli.us> <20180106080728.GA2099@nanopsycho> <20180106094825.GB2099@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: Jamal Hadi Salim , Jiri Pirko Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:37577 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbeAFT3G (ORCPT ); Sat, 6 Jan 2018 14:29:06 -0500 Received: by mail-pl0-f68.google.com with SMTP id s3so5147901plp.4 for ; Sat, 06 Jan 2018 11:29:05 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/6/18 11:02 AM, Jamal Hadi Salim wrote: > BTW: From your output, DavidA, i noticed something strange: > two flower filters with the same handle id 0x1 (different prios) > and also two filters with the same prio (but different handles). > I see one was added using :dev .." - how were the other 2 added? > Consequence of patch, maybe? Not clear from the command history. I was running commands (add by device and add by block) in various orders to see what happens. > > Note: > Expected behavior is two filters of same kind on the same chain > should be distinguished by priority. There are filters like u32 > (which hide hash tables under the same priority) which may > allow the same prio for multiple handles - just dont see that > fit with flower, but maybe missing something. > > cheers, > jamal