From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document "external" parameter handling. Date: Thu, 28 Dec 2017 07:31:46 +0200 Message-ID: References: <1514374096-1473-1-git-send-email-serhe.popovych@gmail.com> <20171227134712.12338c7c@xeon-e3> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OjdI2S9mO6j6SGPOiuhy4RrByFhB6ANr7" Cc: netdev@vger.kernel.org, u9012063@gmail.com To: Stephen Hemminger Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:40806 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbdL1FcF (ORCPT ); Thu, 28 Dec 2017 00:32:05 -0500 Received: by mail-lf0-f68.google.com with SMTP id u84so24265950lff.7 for ; Wed, 27 Dec 2017 21:32:04 -0800 (PST) In-Reply-To: <20171227134712.12338c7c@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OjdI2S9mO6j6SGPOiuhy4RrByFhB6ANr7 Content-Type: multipart/mixed; boundary="UC9DVttvI1tMAz4nYpVnjWdxAbVHRpzNi"; protected-headers="v1" From: Serhey Popovych To: Stephen Hemminger Cc: netdev@vger.kernel.org, u9012063@gmail.com Message-ID: Subject: Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document "external" parameter handling. References: <1514374096-1473-1-git-send-email-serhe.popovych@gmail.com> <20171227134712.12338c7c@xeon-e3> In-Reply-To: <20171227134712.12338c7c@xeon-e3> --UC9DVttvI1tMAz4nYpVnjWdxAbVHRpzNi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Stephen Hemminger wrote: > On Wed, 27 Dec 2017 13:28:13 +0200 > Serhey Popovych wrote: >=20 >> In this series I present next set of improvements/fixes: >> >> 1) Fix noencap- option handling: we need to clear bit, instead >> of seting all, but one we expect to clear. >> >> 2) Document "external" parameter both in ip-link(8) and help >> output for link_gre.c. Add "noexternal" option variant to >> bring inline with GENEVE and VXLAN. >> >> 3) Trivial: clear flowlabel/tclass from flowinfo in case of >> inherit to stop sending garbage to the kernel. It has no >> functional change, but follows similar behaviour in link_ip6tnl.c= >> >> See individual patch description message for details. >> >> Thanks, >> Serhii >> >> Serhey Popovych (3): >> gre,ip6tnl/tunnel: Fix noencap- support >> gre6/tunnel: Do not submit garbage in flowinfo >> ip/tunnel: Document "external" parameter >> >> ip/link_gre.c | 7 +++++-- >> ip/link_gre6.c | 4 ++-- >> ip/link_ip6tnl.c | 6 ++++-- >> ip/link_iptnl.c | 4 +++- >> man/man8/ip-link.8.in | 6 ++++++ >> 5 files changed, 20 insertions(+), 7 deletions(-) >> >=20 > These are really disjoint. I applied the noencap and the flowinfo patch= =2E > Agree with William that having noexternal which does nothing useful is = of little value now. Agree with you guys, just added it to match GENEVE/VXLAN implementation which is has "noexternal". Will send v2 to just document "external" and clear flowlabel/tclass in flowinfo in case of inherit. I have plans for iproute2-next to merge link_{gre,vti}{,6}.c and link_ip{6,}tnl.c functionality together and just want to do things as clear as possible before doing merge. This is to reduce size of ip(8) binary to help openwrt like solutions to survive JSON print support that increases size of binary. Thank you for quick review and good feed back! >=20 --UC9DVttvI1tMAz4nYpVnjWdxAbVHRpzNi-- --OjdI2S9mO6j6SGPOiuhy4RrByFhB6ANr7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJaRIHTAAoJEBTawMmQ61bBFscIAInuHyew7JVkckBTJmhEhqLX oAI2aczOMGBKHhW3foScN3OgGqY3G6N4NNd0SL88HiRDW2zogmjSabhi+r6HmShb fO45lDy9OSmlDIrL048BFrkA5ac7PABGitjLejVyooT6YQsoPCmiMqSKnwIMHSOg PmsnWsDMtCpSa6XAwMaDiNvZm+/RgY4gyq5pTpoCR5Rynt5m7AMIH58BSfZHMXXk d7w4D9mfsR+aA0oNY/ByqNTxf1kEIifBbcopJRC8fwcBUOJScDGExccp0ETNPqtO LHmvxmiCtGgtbRsKJp5JE4cITmab6Bg3uYthFREuKUX66ZKiJsMRPbCl83DIrxY= =ZXsk -----END PGP SIGNATURE----- --OjdI2S9mO6j6SGPOiuhy4RrByFhB6ANr7--