From: okaya@codeaurora.org
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, timur@codeaurora.org,
sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb()
Date: Wed, 21 Mar 2018 17:51:23 -0400 [thread overview]
Message-ID: <c2ce63d1213b5145f77bf70f57c3360d@codeaurora.org> (raw)
In-Reply-To: <1521668888.12746.32.camel@intel.com>
On 2018-03-21 17:48, Jeff Kirsher wrote:
> On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote:
>> Remove ixgbevf_write_tail() in favor of moving writel() close to
>> wmb().
>>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>> Reviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>
>> ---
>> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 -----
>> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
>> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> This patch fails to compile because there is a call to
> ixgbevf_write_tail() which you missed cleaning up.
Hah, I did a compile test but maybe I missed something. I will get v6 of
this patch only and leave the rest of the series as it is.
next prev parent reply other threads:[~2018-03-21 21:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 18:56 [PATCH REPOST v4 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 1/7] i40e/i40evf: " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 2/7] ixgbe: eliminate " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 3/7] igbvf: " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 4/7] igb: " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-03-21 21:48 ` Jeff Kirsher
2018-03-21 21:51 ` okaya [this message]
2018-03-21 21:53 ` [Intel-wired-lan] " Alexander Duyck
2018-03-21 21:54 ` David Miller
2018-03-21 22:14 ` okaya
2018-03-21 18:56 ` [PATCH REPOST v4 6/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 7/7] fm10k: Eliminate " Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2ce63d1213b5145f77bf70f57c3360d@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).