From: Dan Carpenter <dan.carpenter@linaro.org>
To: Matthew Wilcox <willy@infradead.org>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, pierre@stackhpc.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, maxime.chevallier@bootlin.com,
christophe.leroy@csgroup.eu, arkadiusz.kubalewski@intel.com,
vadim.fedorenko@linux.dev
Subject: Re: [PATCH net v2 0/3] fix xa_alloc_cyclic() return checks
Date: Fri, 14 Mar 2025 13:23:04 +0300 [thread overview]
Message-ID: <c2d160cd-b128-47ea-be0c-9775aa6ea0cc@stanley.mountain> (raw)
In-Reply-To: <20250312095251.2554708-1-michal.swiatkowski@linux.intel.com>
On Wed, Mar 12, 2025 at 10:52:48AM +0100, Michal Swiatkowski wrote:
> Pierre Riteau <pierre@stackhpc.com> found suspicious handling an error
> from xa_alloc_cyclic() in scheduler code [1]. The same is done in few
> other places.
>
> v1 --> v2: [2]
> * add fixes tags
> * fix also the same usage in dpll and phy
>
> [1] https://lore.kernel.org/netdev/20250213223610.320278-1-pierre@stackhpc.com/
> [2] https://lore.kernel.org/netdev/20250214132453.4108-1-michal.swiatkowski@linux.intel.com/
>
> Michal Swiatkowski (3):
> devlink: fix xa_alloc_cyclic() error handling
> dpll: fix xa_alloc_cyclic() error handling
> phy: fix xa_alloc_cyclic() error handling
Maybe there should be a wrapper around xa_alloc_cyclic() for people who
don't care about the 1 return?
int wrapper()
{
ret = xa_alloc_cyclic();
if (ret < 0)
return ret;
rerturn 0;
}
regards,
dan carpenter
next prev parent reply other threads:[~2025-03-14 10:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 9:52 [PATCH net v2 0/3] fix xa_alloc_cyclic() return checks Michal Swiatkowski
2025-03-12 9:52 ` [PATCH net v2 1/3] devlink: fix xa_alloc_cyclic() error handling Michal Swiatkowski
2025-03-12 13:15 ` Andrew Lunn
2025-03-14 13:33 ` Jiri Pirko
2025-03-12 9:52 ` [PATCH net v2 2/3] dpll: " Michal Swiatkowski
2025-03-12 10:33 ` Vadim Fedorenko
2025-03-12 10:55 ` Kubalewski, Arkadiusz
2025-03-14 13:33 ` Jiri Pirko
2025-03-12 9:52 ` [PATCH net v2 3/3] phy: " Michal Swiatkowski
2025-03-12 11:35 ` Maxime Chevallier
2025-03-14 10:23 ` Dan Carpenter [this message]
2025-03-14 12:52 ` [PATCH net v2 0/3] fix xa_alloc_cyclic() return checks Przemek Kitszel
2025-03-14 14:13 ` Dan Carpenter
2025-03-14 14:23 ` Matthew Wilcox
2025-03-17 8:55 ` Przemek Kitszel
2025-03-17 12:24 ` Matthew Wilcox
2025-03-19 8:45 ` Przemek Kitszel
2025-03-19 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2d160cd-b128-47ea-be0c-9775aa6ea0cc@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pierre@stackhpc.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox