From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E30D234106A for ; Tue, 27 Jan 2026 10:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510476; cv=none; b=PvAFRpL4BaOQHl6i5R8LsQphUsGU8eoXCkOpvwl3Sc0uYP5LuRKbg1/c503q4N37Lv9DgFYiLTWdaq27KQCfKq+A5vzLeEIjfS5y5Ipv2cBsVyuXgEFrQRT/5XdcTfsMVNy/GEGkk/UNB4fu/ABDAxq2KImMe0G558ux8qRHL88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510476; c=relaxed/simple; bh=ep8pkCwlbUpSN66L5MpDnjNjWPh2mpgjhXM0xSkHFh4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hldR6dj6rIGK8CyrI1G2sgv/UOe5rlHWgaBKbqaArMVM/Yf5K5MYmhMRgZjLDZNUShqQ48ePd94KQJJup1LSojWS6CNLvhetvJK+I29EmIuDcRn5J4D7NXeM4LFNOVGWrIoHH/KNe/9QhEDG38CFP9vOxIq2Vk242teC16dyfrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GEI/wOju; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jhub10ew; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GEI/wOju"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jhub10ew" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769510474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Euj5FVmeiCgVhty6Ys/ujWG8Y866aXXG7V4F32PyIco=; b=GEI/wOjubrl3nCtlxtJmoQnpys8j+3FmRJRf9UOTdWAkBiElNgZM2y0i462xSUR75inZiP juPIufIAqom9vM8v9chjejuckkcap7bJfjRIZtOGYqTLMYSQAy8UYNjcm3wWn8eFSCa5kk Dy9bEIfQ0O2EZUCD13p7AcmKNjBR62A= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-KiZqlVxfPFSzzMhrK_IhKQ-1; Tue, 27 Jan 2026 05:41:06 -0500 X-MC-Unique: KiZqlVxfPFSzzMhrK_IhKQ-1 X-Mimecast-MFC-AGG-ID: KiZqlVxfPFSzzMhrK_IhKQ_1769510465 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-59b70088327so3325562e87.1 for ; Tue, 27 Jan 2026 02:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769510464; x=1770115264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Euj5FVmeiCgVhty6Ys/ujWG8Y866aXXG7V4F32PyIco=; b=jhub10ewdGewbax9zYjq3xfVBunI0eM2we7Uume9dL2DConQcshOLR3fUrNVNaLcfi NQEkRkUogVl8IsM6bahZGZtOe2BDd+bvxYN9ohmk6e5QHGEPREV2gxi7/te+91OXSsOv 1ERjmLMXoidIyEvpXpoVT1aq0IYaXVHcK7SLw2a7WT7xqRstVqztebhi+4ueBPqt5QlJ Wl77P2esxG1IWHXHMJIWcfDdKf7yGFGGb21DfokVSva8mXg0ShvhvnOiIyLd0sKaea6e etIEV9QtL8eNFTbjamsOCtFQTOKzha3PWsIzZ/05IlY8Nw/68eQka9YU42HLsFqsj55h m3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769510464; x=1770115264; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Euj5FVmeiCgVhty6Ys/ujWG8Y866aXXG7V4F32PyIco=; b=pF5VLXyL7mmzLBU8m0Q+Jvfqgx23PmTOpP7u27A8y9OlxCQnMdMgZpAvEnKe9J0QSf m1n/YbDi7btuEkZ2ii3Ay96MmK/ngDsUdA51n7gFjc2r73NcWxW3jlPA9pK2qQkjl5q2 88ePNxx1eGLBhgIbHa4Z+P1tSIdzkncKhHqp8ilTLJ2mEaiblBets+LiwHtEt1+eni4z WZPOPilu4nPhXHSRwEPksydooqkQ5wkHt/xdXXo6UdXz5HbnVOeqsi2JTKiyDT4hfzAr wdwhlZJ4eH+YdexiSzJF2WgAEz32yS6TFQN4SBlLjvWxTvoOCYuYczaVv/NsimsoeHPS jP/w== X-Forwarded-Encrypted: i=1; AJvYcCWEYoMSj7FNHI3qt7yhpyBTNuUNjkC6vJckO6uKrQ+S6kUbXt+uPwpxbe0h/F+o3YAYBXQH5wg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb8OU8l1GuWLStis05HVKQGIK/IeVpDQw4cXbR9jKId9y7kylt CK/gAN/W4Oqd2VyVqj9eRQajsJnX0DkMIddzt3XYk61QCFvOUs4F5aBN5xrssvFAMad7Uz74vi7 hmASaTHuPjh37uQNsNzjrMKPqCU1GEplkgSWXyhuaCGGpTzXepOITinxlE8G35kkIBA== X-Gm-Gg: AZuq6aLUlxplIJpFtjQ3hk0xHdLK15Sxg0mlj8GjSyBKtI2OvJgAV0z24teRvG379J3 fiOkGRb18kO8xj8jJ4KmSRra8OvnXJeG4KhV8buGKRXPvfzrXHqVvykpOCzS5Vpfv/HscyudfwT 8cFhFs1VnX0F69J3jAxnM+cPvjpU0MHopAqfQmf08ToWfidoI5PAO9siVxT7dZs4e23Cn3N7nLf ucaoELWRlGiVUBAbxNYqVbiBoJ+OIFtnoX3iW23aDqbS+Yzoau5mXGFBcuW/GhIBRtKW5uCbi9w s0taaiOrJ4xUIYYl+uxREKBbrgcA01t+Rfm/3gY82llEsoOgsGTpk5pRfKPzQSHa08zao1yl0i7 ib4xc7z1ZT60x X-Received: by 2002:a05:6512:3b91:b0:59d:fd1e:50da with SMTP id 2adb3069b0e04-59e040308e5mr507774e87.36.1769510464434; Tue, 27 Jan 2026 02:41:04 -0800 (PST) X-Received: by 2002:a05:6512:3b91:b0:59d:fd1e:50da with SMTP id 2adb3069b0e04-59e040308e5mr507755e87.36.1769510463979; Tue, 27 Jan 2026 02:41:03 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.22]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59de492cc4asm3330939e87.101.2026.01.27.02.41.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 02:41:03 -0800 (PST) Message-ID: Date: Tue, 27 Jan 2026 11:41:00 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 4/4] net: dsa: add basic initial driver for MxL862xx switches To: Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Simon Horman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin References: <18c6a24eef8617abb5073569fee162f1aa1c06ea.1769053079.git.daniel@makrotopia.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <18c6a24eef8617abb5073569fee162f1aa1c06ea.1769053079.git.daniel@makrotopia.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/22/26 4:42 AM, Daniel Golle wrote: > +static int mxl862xx_send_cmd(struct mxl862xx_priv *priv, u16 cmd, u16 size, > + bool quiet) > +{ > + int ret; > + > + ret = mxl862xx_reg_write(priv, MXL862XX_MMD_REG_LEN_RET, size); > + if (ret) > + return ret; > + > + ret = mxl862xx_reg_write(priv, MXL862XX_MMD_REG_CTRL, > + cmd | CTRL_BUSY_MASK); > + if (ret) > + return ret; > + > + ret = mxl862xx_busy_wait(priv); > + if (ret) > + return ret; > + > + ret = mxl862xx_reg_read(priv, MXL862XX_MMD_REG_LEN_RET); > + /* handle errors returned by the firmware as -EIO > + * The firmware is based on Zephyr OS and uses the errors as > + * defined in errno.h of Zephyr OS. See > + * https://github.com/zephyrproject-rtos/zephyr/blob/v3.7.0/lib/libc/minimal/include/errno.h > + */ > + if ((s16)ret < 0) { The cast is likely not needed above? if `ret` values < S16_MIN are possible this will return such values to the caller without the IO err printk. > + if (!quiet) > + dev_err(&priv->mdiodev->dev, > + "CMD %04x returned error %d\n", cmd, (s16)ret); > + return -EIO; > + } > + > + return ret; > +} > + > +int mxl862xx_api_wrap(struct mxl862xx_priv *priv, u16 cmd, void *_data, > + u16 size, bool read, bool quiet) > +{ > + __le16 *data = _data; > + u16 max, i; > + int ret, cmd_ret; Minor nit: reverse christmas tree above. BTW the initial port isolation LGTM, but I would appreciate some DSA expert second opinion. Thanks, Paolo