From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Nambiar, Amritha" <amritha.nambiar@intel.com>
Subject: Re: [net-next, RFC PATCH] net: sched: cls_range: Introduce Range
 classifier
Date: Fri, 14 Sep 2018 18:31:22 -0700
Message-ID: <c2f10515-b484-2965-ac1f-c46ad9705bd3@intel.com>
References: <153687160312.43503.11156697286063840163.stgit@anamhost.jf.intel.com>
 <153687192654.43503.1433255216543560934.stgit@anamhost.jf.intel.com>
 <20180914095813.GL25110@nanopsycho>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        alexander.h.duyck@intel.com, jakub.kicinski@netronome.com,
        sridhar.samudrala@intel.com, jhs@mojatatu.com,
        jesse.brandeburg@intel.com, xiyou.wangcong@gmail.com
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga03.intel.com ([134.134.136.65]:52970 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726181AbeIOGsY (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 15 Sep 2018 02:48:24 -0400
In-Reply-To: <20180914095813.GL25110@nanopsycho>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 9/14/2018 2:58 AM, Jiri Pirko wrote:
> Thu, Sep 13, 2018 at 10:52:06PM CEST, amritha.nambiar@intel.com wrote:
> 
> [...]
> 
>> +static struct cls_range_filter *range_lookup(struct cls_range_head *head,
>> +					     struct range_flow_key *key,
>> +					     struct range_flow_key *mkey,
>> +					     bool is_skb)
>> +{
>> +	struct cls_range_filter *filter, *next_filter;
>> +	struct range_params range;
>> +	int ret;
>> +	size_t cmp_size;
>> +
>> +	list_for_each_entry_safe(filter, next_filter, &head->filters, flist) {
> 
> This really should be list_for_each_entry_rcu()
> 
> also, as I wrote in the previous email, this should be done in
> cls_flower. Look at fl_lookup() it looks-up hashtable. You just need to
> add linked list traversal and range comparison to that function for the
> hit in the hashtable.
> 

I see. Will integrate the range comparison into cls_flower.

> 
>> +		if (!is_skb) {
>> +			/* Existing filter comparison */
>> +			cmp_size = sizeof(filter->mkey);
>> +		} else {
>> +			/* skb classification */
>> +			ret = range_compare_params(&range, filter, key,
>> +						   RANGE_PORT_DST);
>> +			if (ret < 0)
>> +				continue;
>> +
>> +			ret = range_compare_params(&range, filter, key,
>> +						   RANGE_PORT_SRC);
>> +			if (ret < 0)
>> +				continue;
>> +
>> +			/* skb does not have min and max values */
>> +			cmp_size = RANGE_KEY_MEMBER_OFFSET(tp_min);
>> +		}
>> +		if (!memcmp(mkey, &filter->mkey, cmp_size))
>> +			return filter;
>> +	}
>> +	return NULL;
> 
> [...]
>