From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info Date: Mon, 16 Apr 2018 13:50:07 -0600 Message-ID: References: <20180416152255.2256-1-dsahern@gmail.com> <20180416152255.2256-8-dsahern@gmail.com> <20180416.152033.1080883507779037027.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, idosch@idosch.org, roopa@cumulusnetworks.com, eric.dumazet@gmail.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org To: David Miller Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:40629 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbeDPTtv (ORCPT ); Mon, 16 Apr 2018 15:49:51 -0400 Received: by mail-pf0-f196.google.com with SMTP id y66so11024769pfi.7 for ; Mon, 16 Apr 2018 12:49:51 -0700 (PDT) In-Reply-To: <20180416.152033.1080883507779037027.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/16/18 1:20 PM, David Miller wrote: > From: David Ahern > Date: Mon, 16 Apr 2018 08:22:41 -0700 > >> @@ -2394,6 +2395,7 @@ static void addrconf_add_mroute(struct net_device *dev) >> .fc_ifindex = dev->ifindex, >> .fc_dst_len = 8, >> .fc_flags = RTF_UP, >> + .fc_type = RTN_UNICAST, >> .fc_nlinfo.nl_net = dev_net(dev), >> }; >> > > Multicast route is of type RTN_UNICAST? > > All of these cases where passing in a zero initialized value of > fc_type up until this patch. Perhaps you should discuss that in your > commit message a little bit. Added this to the commit message: fc_type is set in current users based on the algorithm in rt6_fill_node: - rt6i_flags contains RTF_LOCAL: fc_type = RTN_LOCAL - rt6i_flags contains RTF_ANYCAST: fc_type = RTN_ANYCAST - else fc_type = RTN_UNICAST Similarly, fib6_type is set in the rt6_info templates based on the RTF_REJECT section of rt6_fill_node converting dst.error to RTN type. ##### Will send a v2 later this week.