From: Martin Kaistra <martin.kaistra@linutronix.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH v2 1/7] net: dsa: b53: Add BroadSync HD register definitions
Date: Wed, 10 Nov 2021 09:19:04 +0100 [thread overview]
Message-ID: <c342fbf3-44b2-ce22-888f-363b709ea986@linutronix.de> (raw)
In-Reply-To: <6839c4e9-123d-227a-630d-fae8a2df6483@gmail.com>
Am 09.11.21 um 19:04 schrieb Florian Fainelli:
> On 11/9/21 1:50 AM, Martin Kaistra wrote:
>> From: Kurt Kanzenbach <kurt@linutronix.de>
>>
>> Add register definitions for the BroadSync HD features of
>> BCM53128. These will be used to enable PTP support.
>>
>> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>> Signed-off-by: Martin Kaistra <martin.kaistra@linutronix.de>
>> ---
>
> [snip]
>
>> +/*************************************************************************
>> + * ARL Control Registers
>> + *************************************************************************/
>> +
>> +/* Multiport Control Register (16 bit) */
>> +#define B53_MPORT_CTRL 0x0e
>> +#define MPORT_CTRL_DIS_FORWARD 0
>> +#define MPORT_CTRL_CMP_ETYPE 1
>> +#define MPORT_CTRL_CMP_ADDR 2
>> +#define MPORT_CTRL_CMP_ADDR_ETYPE 3
>> +#define MPORT_CTRL_SHIFT(x) ((x) << 1)
>> +#define MPORT_CTRL_MASK 0x2
>
> The mask should be 0x3 since this is a 2-bit wide field.
>
Correct, thanks.
Currently, this mask is not used, as I am just writing
MPORT0_TS_EN |
(MPORT_CTRL_CMP_ETYPE << MPORT_CTRL_SHIFT(0))
to the register. Should I keep the definition anyway?
next prev parent reply other threads:[~2021-11-10 8:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 9:50 [PATCH v2 0/7] Add PTP support for BCM53128 switch Martin Kaistra
2021-11-09 9:50 ` [PATCH v2 1/7] net: dsa: b53: Add BroadSync HD register definitions Martin Kaistra
2021-11-09 10:10 ` Kurt Kanzenbach
2021-11-09 18:04 ` Florian Fainelli
2021-11-10 8:19 ` Martin Kaistra [this message]
2021-11-09 9:50 ` [PATCH v2 2/7] net: dsa: b53: Move struct b53_device to include/linux/dsa/b53.h Martin Kaistra
2021-11-09 18:05 ` Florian Fainelli
2021-11-09 18:11 ` Florian Fainelli
2021-11-09 18:15 ` Vladimir Oltean
2021-11-09 18:20 ` Florian Fainelli
2021-11-09 18:49 ` Vladimir Oltean
2021-11-09 9:50 ` [PATCH v2 3/7] timecounter: allow for non-power of two overflow Martin Kaistra
2021-11-24 20:55 ` Thomas Gleixner
2021-11-09 9:50 ` [PATCH v2 4/7] net: dsa: b53: Add PHC clock support Martin Kaistra
2021-11-09 18:08 ` Florian Fainelli
2021-11-09 9:50 ` [PATCH v2 5/7] net: dsa: b53: Add logic for RX timestamping Martin Kaistra
2021-11-09 18:07 ` Florian Fainelli
2021-11-10 8:43 ` Martin Kaistra
2021-11-09 9:50 ` [PATCH v2 6/7] net: dsa: b53: Add logic for TX timestamping Martin Kaistra
2021-11-09 11:12 ` Vladimir Oltean
2021-11-10 7:14 ` Kurt Kanzenbach
2021-11-10 13:05 ` Vladimir Oltean
2021-11-10 13:30 ` Vladimir Oltean
2021-11-10 13:47 ` Kurt Kanzenbach
2021-11-10 14:00 ` Vladimir Oltean
2021-11-10 15:08 ` Richard Cochran
2021-11-10 15:23 ` Vladimir Oltean
2021-11-10 12:57 ` Vladimir Oltean
2021-11-09 9:50 ` [PATCH v2 7/7] net: dsa: b53: Expose PTP timestamping ioctls to userspace Martin Kaistra
2021-11-09 10:39 ` [PATCH v2 0/7] Add PTP support for BCM53128 switch Vladimir Oltean
2021-11-09 11:13 ` Martin Kaistra
2021-11-09 18:13 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c342fbf3-44b2-ce22-888f-363b709ea986@linutronix.de \
--to=martin.kaistra@linutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john.stultz@linaro.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).