netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH iproute2 net-next] vxlan: fix ttl inherit behavior
Date: Thu, 19 Apr 2018 12:15:33 -0600	[thread overview]
Message-ID: <c34e4c8b-f115-e77c-7228-82bab11fb54b@gmail.com> (raw)
In-Reply-To: <1524027948-5395-1-git-send-email-liuhangbin@gmail.com>

On 4/17/18 11:05 PM, Hangbin Liu wrote:
> Like kernel net-next commit 72f6d71e491e6 ("vxlan: add ttl inherit support"),
> vxlan ttl inherit should means inherit the inner protocol's ttl value.
> 
> But currently when we add vxlan with "ttl inherit", we only set ttl 0,
> which is actually use whatever default value instead of inherit the inner
> protocol's ttl value.
> 
> To make a difference with ttl inherit and ttl == 0, we add an attribute
> IFLA_VXLAN_TTL_INHERIT when "ttl inherit" specified. And use "ttl auto"
> to means "use whatever default value", the same behavior with ttl == 0.
> 
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Suggested-by: Jiri Benc <jbenc@redhat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  include/uapi/linux/if_link.h | 1 +
>  ip/iplink_vxlan.c            | 8 ++++++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 

applied to iproute2-next.

      parent reply	other threads:[~2018-04-19 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  5:05 [PATCH iproute2 net-next] vxlan: fix ttl inherit behavior Hangbin Liu
2018-04-18  5:10 ` Hangbin Liu
2018-04-18 15:50   ` Stephen Hemminger
2018-04-19  0:09     ` Hangbin Liu
2018-04-19 18:15 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c34e4c8b-f115-e77c-7228-82bab11fb54b@gmail.com \
    --to=dsahern@gmail.com \
    --cc=jbenc@redhat.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).