From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@mellanox.com,
jakub.kicinski@netronome.com, roopa@cumulusnetworks.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 02/10] ipv4: Encapsulate function arguments in a struct
Date: Wed, 8 Jan 2020 11:37:28 -0700 [thread overview]
Message-ID: <c35c97d7-d1dc-d0d6-6ea8-deaf33441c7c@gmail.com> (raw)
In-Reply-To: <20200107154517.239665-3-idosch@idosch.org>
On 1/7/20 8:45 AM, Ido Schimmel wrote:
> diff --git a/net/ipv4/fib_lookup.h b/net/ipv4/fib_lookup.h
> index a68b5e21ec51..b34594a9965f 100644
> --- a/net/ipv4/fib_lookup.h
> +++ b/net/ipv4/fib_lookup.h
> @@ -21,6 +21,15 @@ struct fib_alias {
>
> #define FA_S_ACCESSED 0x01
>
> +struct fib_rt_info {
> + struct fib_info *fi;
> + u32 tb_id;
> + __be32 dst;
> + int dst_len;
> + u8 tos;
> + u8 type;
> +};
> +
> /* Dont write on fa_state unless needed, to keep it shared on all cpus */
> static inline void fib_alias_accessed(struct fib_alias *fa)
> {
> @@ -35,9 +44,8 @@ struct fib_info *fib_create_info(struct fib_config *cfg,
> int fib_nh_match(struct fib_config *cfg, struct fib_info *fi,
> struct netlink_ext_ack *extack);
> bool fib_metrics_match(struct fib_config *cfg, struct fib_info *fi);
> -int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, u32 tb_id,
> - u8 type, __be32 dst, int dst_len, u8 tos, struct fib_info *fi,
> - unsigned int);
> +int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event,
> + struct fib_rt_info *fri, unsigned int);
since you are modifying this, can you add a name for that last argument?
Otherwise, nice cleanup.
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2020-01-08 18:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 15:45 [PATCH net-next 00/10] net: Add route offload indication Ido Schimmel
2020-01-07 15:45 ` [PATCH net-next 01/10] ipv4: Replace route in list before notifying Ido Schimmel
2020-01-08 18:33 ` David Ahern
2020-01-07 15:45 ` [PATCH net-next 02/10] ipv4: Encapsulate function arguments in a struct Ido Schimmel
2020-01-08 18:37 ` David Ahern [this message]
2020-01-09 8:26 ` Ido Schimmel
2020-01-07 15:45 ` [PATCH net-next 03/10] ipv4: Add "offload" and "trap" indications to routes Ido Schimmel
2020-01-09 15:47 ` David Ahern
2020-01-07 15:45 ` [PATCH net-next 04/10] ipv6: " Ido Schimmel
2020-01-09 15:48 ` David Ahern
2020-01-09 16:24 ` Roopa Prabhu
2020-01-07 15:45 ` [PATCH net-next 05/10] mlxsw: spectrum_router: Separate nexthop offload indication from route Ido Schimmel
2020-01-07 15:45 ` [PATCH net-next 06/10] mlxsw: spectrum_router: Set hardware flags for routes Ido Schimmel
2020-01-07 15:45 ` [PATCH net-next 07/10] netdevsim: fib: Add dummy implementation for FIB offload Ido Schimmel
2020-01-07 15:45 ` [PATCH net-next 08/10] selftests: forwarding: Add helpers and tests " Ido Schimmel
2020-01-07 15:45 ` [PATCH net-next 09/10] selftests: netdevsim: Add test for FIB offload API Ido Schimmel
2020-01-07 15:45 ` [PATCH net-next 10/10] selftests: mlxsw: " Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c35c97d7-d1dc-d0d6-6ea8-deaf33441c7c@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).