From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 134D1C33CA2 for ; Wed, 8 Jan 2020 18:37:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E366B2067D for ; Wed, 8 Jan 2020 18:37:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n0QuYAFn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbgAHShb (ORCPT ); Wed, 8 Jan 2020 13:37:31 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:44073 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbgAHSha (ORCPT ); Wed, 8 Jan 2020 13:37:30 -0500 Received: by mail-io1-f68.google.com with SMTP id b10so4247529iof.11 for ; Wed, 08 Jan 2020 10:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hk1Kq6Dpojomo9iAYHQJvWF5j1qQEv1wXmovGYH98vA=; b=n0QuYAFn9iDVlvnB3kN/zuJf29g0REEci/dBdS81ddEfWS9DCKoj1vvUSr1uGAWpS+ 2DRtViZ0YQI4gMteFMfpvmW1kAc4oORjZZdLOtAj5p7ILAipDnahM3Xi2gb59hcMOcZ+ 3T/syq5SAM28JgAkSHkcFU0+REEASrpfo2HFcuSXkr8t3ID2XqV7CuMtggO1ZuwPay+R gsx7L2SlAzSiVoE3nLpyIdAOqNbirpPo5wP3b5y6AHmhEdYe4k1Sth8gKIeghEQi4aWM 7ZVHT8Z5/ocOFstbCAZbqKZYst8MpFykp7ljDK51zEac28CcEP0BzvnufmOI7fNjrm73 Qdwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hk1Kq6Dpojomo9iAYHQJvWF5j1qQEv1wXmovGYH98vA=; b=JsDWefgmii9xvGDUiv5pT6NmxkRQL/dhtldq6MiKpQBSZPD11J4D9EzPK3HmdAB0hZ UGDPLaRzPmJAwHzCz6C51XU1VzNqApe3ArTJG4wee1xk7YW4quG/xuxsSV+pZu9YyCWW dwmAc8Vq3c5YMYJoECFFulG+ZMz+IIa94s9j5MVGc2Yt0sseZf/sYopPLEquAcnFhB6Z NQm2d5hTzx4n35HjZ2/6QyeZt3jinDua0aY3oZfq7c0NTdyvobKveUt5k7j6VEo9WJfe Rkl5/tWQrG09ZgJmuItV+h2ArD3soxAaAfygdBDUBlQRoQSFG7DAI3FdZgcfa/iy0NC1 z+Yw== X-Gm-Message-State: APjAAAUftUH9GsDB0is9fsuXxBV/tc+lNs9d2ppVF/pZGwK8AUJenJgN CIjGcOZPQHT+B9LFzNe18DM= X-Google-Smtp-Source: APXvYqw+ZK3je0gUQox1Lbd5NtLpY3MMmQRH7SWTT16io/ajdvDNzTFGVyVC3TY5vWTmKcXX2CAung== X-Received: by 2002:a6b:8b01:: with SMTP id n1mr4441010iod.111.1578508650035; Wed, 08 Jan 2020 10:37:30 -0800 (PST) Received: from ?IPv6:2601:282:800:7a:601d:4dc7:bf1b:dae9? ([2601:282:800:7a:601d:4dc7:bf1b:dae9]) by smtp.googlemail.com with ESMTPSA id a9sm1191058ilk.14.2020.01.08.10.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 10:37:29 -0800 (PST) Subject: Re: [PATCH net-next 02/10] ipv4: Encapsulate function arguments in a struct To: Ido Schimmel , netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, jakub.kicinski@netronome.com, roopa@cumulusnetworks.com, mlxsw@mellanox.com, Ido Schimmel References: <20200107154517.239665-1-idosch@idosch.org> <20200107154517.239665-3-idosch@idosch.org> From: David Ahern Message-ID: Date: Wed, 8 Jan 2020 11:37:28 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200107154517.239665-3-idosch@idosch.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/7/20 8:45 AM, Ido Schimmel wrote: > diff --git a/net/ipv4/fib_lookup.h b/net/ipv4/fib_lookup.h > index a68b5e21ec51..b34594a9965f 100644 > --- a/net/ipv4/fib_lookup.h > +++ b/net/ipv4/fib_lookup.h > @@ -21,6 +21,15 @@ struct fib_alias { > > #define FA_S_ACCESSED 0x01 > > +struct fib_rt_info { > + struct fib_info *fi; > + u32 tb_id; > + __be32 dst; > + int dst_len; > + u8 tos; > + u8 type; > +}; > + > /* Dont write on fa_state unless needed, to keep it shared on all cpus */ > static inline void fib_alias_accessed(struct fib_alias *fa) > { > @@ -35,9 +44,8 @@ struct fib_info *fib_create_info(struct fib_config *cfg, > int fib_nh_match(struct fib_config *cfg, struct fib_info *fi, > struct netlink_ext_ack *extack); > bool fib_metrics_match(struct fib_config *cfg, struct fib_info *fi); > -int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, u32 tb_id, > - u8 type, __be32 dst, int dst_len, u8 tos, struct fib_info *fi, > - unsigned int); > +int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, > + struct fib_rt_info *fri, unsigned int); since you are modifying this, can you add a name for that last argument? Otherwise, nice cleanup. Reviewed-by: David Ahern