From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tariq Toukan Subject: Re: [PATCH bpf-next v2 03/11] bpf: make mlx4 compatible w/ bpf_xdp_adjust_tail Date: Wed, 18 Apr 2018 13:53:41 +0300 Message-ID: References: <20180418042951.17183-1-tehnerd@tehnerd.com> <20180418042951.17183-4-tehnerd@tehnerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: "Nikita V. Shirokov" , Alexei Starovoitov , Daniel Borkmann , Tariq Toukan Return-path: Received: from mail-db5eur01on0077.outbound.protection.outlook.com ([104.47.2.77]:64107 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751942AbeDRKxz (ORCPT ); Wed, 18 Apr 2018 06:53:55 -0400 In-Reply-To: <20180418042951.17183-4-tehnerd@tehnerd.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 18/04/2018 7:29 AM, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for mlx4 driver we will just calculate packet's length unconditionally > (the same way as it's already being done in mlx5) > > Acked-by: Alexei Starovoitov > --- > drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > index 5c613c6663da..efc55feddc5c 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > @@ -775,8 +775,8 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud > > act = bpf_prog_run_xdp(xdp_prog, &xdp); > > + length = xdp.data_end - xdp.data; > if (xdp.data != orig_data) { > - length = xdp.data_end - xdp.data; > frags[0].page_offset = xdp.data - > xdp.data_hard_start; > va = xdp.data; > Acked-by: Tariq Toukan Thanks.