From: Matthieu Baerts <matttbe@kernel.org>
To: Eric Dumazet <edumazet@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
kuniyu@google.com, ncardwell@google.com, horms@kernel.org,
netdev@vger.kernel.org, imv4bel@gmail.com,
netdev-bot+sashiko@kernel.org
Subject: Re: [PATCH net] tcp: purge Fast Open RST queue when listen() fails
Date: Mon, 16 Nov 2026 17:30:40 +0100 [thread overview]
Message-ID: <c3963b23-5724-470a-8733-14ffed441c0d@kernel.org> (raw)
In-Reply-To: <179477744662.3136.16061867603109307859@kernel.org>
Hi Eric,
On 15/11/2026 22:17, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
(...)
> Could the error path run the full inet_csk_listen_stop() cleanup after
> setting TCP_CLOSE? Alternatively, could TCP_LISTEN be set only after
> get_port() and hash() succeed?
FYI, this is what Chris' patch "tcp: drain the queues of a listen() that
fails" does [1], in a series of fixes sent to the MPTCP ML: it calls
inet_csk_listen_stop() after setting TCP_CLOSE, except for MPTCP
subflows, drained by the next patch. This TCP patch conflicts with yours
here, and also covers the RST queue I think.
(Note that I still need to send a v2 for Chris' series, but with Sashiko
/ Clashiko adding more and more pre-existing issues, I'm now at 50
patches :-/ )
[1]
https://lore.kernel.org/r/20261113-mptcp-cmason-fixes-v1-1-9205b77e9a2f@kernel.org
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2026-11-16 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 11:12 [PATCH net] tcp: purge Fast Open RST queue when listen() fails Eric Dumazet
2026-11-14 16:14 ` Hyunwoo Kim
2026-11-14 17:06 ` Kuniyuki Iwashima
2026-11-15 21:17 ` netdev-bot+sashiko
2026-11-16 16:30 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3963b23-5724-470a-8733-14ffed441c0d@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=imv4bel@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox