From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F38382F39 for ; Thu, 26 Mar 2026 11:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774523210; cv=none; b=KvZf7XtQmsrftYJsHzN3xlWNAefkBdCzo6raWA4W31GsVcPg1UBRajsG1GD78sljcrZtAnQvjRgR3O+JezmIaInNGkLGp6xovTDA+E0yhPMKENEQ7pOBhEJWXU8pXkF7xcnzG+aeakdCWV8OXre6e0uKEUQAKU1wids6lZ5rLvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774523210; c=relaxed/simple; bh=k+wu+2cuNPZeET/Emq8oKs+zlyzXvPmaUY8+O6El8n8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=grt/cTqzwDV1qM5Hj0zemHUeIp2H7qan8I2nkWVCBEsu6pl4nTanJnwok5isOPeH9HJLrt6EeZad8mDn1+m8rsm2aIWCpN6tP7558OaUU8WkwORSK2Ln3FQLpWjZVQKSZtuwJMNjzmIfU/VAif4Xc2VEFyvvAOJP24C/k4xu4SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=GKzQ9M9A; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="GKzQ9M9A" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774523196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t82upu+JkYBPixAK81aWkOm93P++6ewa96nPfYVRcls=; b=GKzQ9M9AR79IL1NcYc6CwQLAjkXvhfgt1JwV5btp0LSD3R71Ah86kpegNAN0AUojCgUmpO ZJCdK2e88XeZ1taR4aVB2ZZgLejnMmchCWNyBG0rn7o7k4EJVAKjVueU/qqrSuMQI+S85K XSGhNNCimStJRgXLVo9pHfTIhZVlyBI= Date: Thu, 26 Mar 2026 11:06:24 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 1/3] dpll: add actual frequency monitoring to netlink spec To: Ivan Vecera , netdev@vger.kernel.org Cc: Arkadiusz Kubalewski , Jiri Pirko , Jonathan Corbet , Shuah Khan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Prathosh Satish , Petr Oros , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325193914.124898-1-ivecera@redhat.com> <20260325193914.124898-2-ivecera@redhat.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20260325193914.124898-2-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 25/03/2026 19:39, Ivan Vecera wrote: > Add DPLL_A_FREQUENCY_MONITOR device attribute to allow control over > the frequency monitor feature. The attribute uses the existing > dpll_feature_state enum (enable/disable) and is present in both > device-get reply and device-set request. > > Add DPLL_A_PIN_ACTUAL_FREQUENCY pin attribute to expose the measured > input frequency in Hz. The attribute is present in the pin-get reply. Overall looks ok, but the wording can be improved, I think. What about using "MEASURED" or "READ" instead of "ACTUAL"? The spec file has this note already, looks like there were some concerns already?