From: subashab@codeaurora.org
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, stranche@codeaurora.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: rmnet: set NETIF_F_LLTX flag
Date: Sun, 08 Mar 2020 18:28:11 -0600 [thread overview]
Message-ID: <c3ae604f1bd130b3c753578aa89087cb@codeaurora.org> (raw)
In-Reply-To: <20200308134706.18727-1-ap420073@gmail.com>
On 2020-03-08 07:47, Taehee Yoo wrote:
> The rmnet_vnd_setup(), which is the callback of ->ndo_start_xmit() is
> allowed to call concurrently because it uses RCU protected data.
> So, it doesn't need tx lock.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> index d7c52e398e4a..d58b51d277f1 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> @@ -212,6 +212,8 @@ void rmnet_vnd_setup(struct net_device *rmnet_dev)
> rmnet_dev->needs_free_netdev = true;
> rmnet_dev->ethtool_ops = &rmnet_ethtool_ops;
>
> + rmnet_dev->features |= NETIF_F_LLTX;
> +
> /* This perm addr will be used as interface identifier by IPv6 */
> rmnet_dev->addr_assign_type = NET_ADDR_RANDOM;
> eth_random_addr(rmnet_dev->perm_addr);
Hi Taehee
It seems the flag is deprecated per documentation.
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/networking/netdevices.txt#n73
next prev parent reply other threads:[~2020-03-09 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 13:47 [PATCH net-next] net: rmnet: set NETIF_F_LLTX flag Taehee Yoo
2020-03-09 0:28 ` subashab [this message]
2020-03-09 0:54 ` Eric Dumazet
2020-03-09 4:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ae604f1bd130b3c753578aa89087cb@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stranche@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).