From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC6E8C10DCE for ; Mon, 9 Mar 2020 00:28:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FD14206D5 for ; Mon, 9 Mar 2020 00:28:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="XqH8rQHI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbgCIA2f (ORCPT ); Sun, 8 Mar 2020 20:28:35 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:35265 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726354AbgCIA2f (ORCPT ); Sun, 8 Mar 2020 20:28:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1583713714; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Da5JPQ8waNhHJz7M7/xg0nq00tT0BWhg583a40BWJA0=; b=XqH8rQHIpn9zdyWlwHDdBbHS5UUZu5YuZ3ZNIX8TpVyYO8JK0C7cIjlfG/xW5eAHlmMHK3Jv 9ne+I2VUQ0dyxOT4eee2afhtEjBRqISPZ9paqeRlgUWyjOfw+PVEsFexVx+EM4j+EQC/RI4S /xJYK8YKT2+ADTO/I/SPRz8CdTw= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e658d9c.7f7bcf394a40-smtp-out-n05; Mon, 09 Mar 2020 00:28:12 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AF033C432C2; Mon, 9 Mar 2020 00:28:11 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: subashab) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3D9F8C433D2; Mon, 9 Mar 2020 00:28:11 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 08 Mar 2020 18:28:11 -0600 From: subashab@codeaurora.org To: Taehee Yoo Cc: davem@davemloft.net, kuba@kernel.org, stranche@codeaurora.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: rmnet: set NETIF_F_LLTX flag In-Reply-To: <20200308134706.18727-1-ap420073@gmail.com> References: <20200308134706.18727-1-ap420073@gmail.com> Message-ID: X-Sender: subashab@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020-03-08 07:47, Taehee Yoo wrote: > The rmnet_vnd_setup(), which is the callback of ->ndo_start_xmit() is > allowed to call concurrently because it uses RCU protected data. > So, it doesn't need tx lock. > > Signed-off-by: Taehee Yoo > --- > drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c > b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c > index d7c52e398e4a..d58b51d277f1 100644 > --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c > +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c > @@ -212,6 +212,8 @@ void rmnet_vnd_setup(struct net_device *rmnet_dev) > rmnet_dev->needs_free_netdev = true; > rmnet_dev->ethtool_ops = &rmnet_ethtool_ops; > > + rmnet_dev->features |= NETIF_F_LLTX; > + > /* This perm addr will be used as interface identifier by IPv6 */ > rmnet_dev->addr_assign_type = NET_ADDR_RANDOM; > eth_random_addr(rmnet_dev->perm_addr); Hi Taehee It seems the flag is deprecated per documentation. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/networking/netdevices.txt#n73