From: Daniel Borkmann <daniel@iogearbox.net>
To: Stanislav Fomichev <sdf@google.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: davem@davemloft.net, ast@kernel.org
Subject: Re: [PATCH bpf-next v2 0/7] selftests: bpf: break up test_progs
Date: Sat, 2 Mar 2019 01:00:49 +0100 [thread overview]
Message-ID: <c3b9965e-b987-a36a-e870-d8f8bb804262@iogearbox.net> (raw)
In-Reply-To: <20190228232440.28668-1-sdf@google.com>
On 03/01/2019 12:24 AM, Stanislav Fomichev wrote:
> Recently we had linux-next bpf/bpf-next conflict when we added new
> functionality to the test_progs.c at the same location. Let's split
> test_progs.c the same way we recently split test_verifier.c.
>
> I follow the same patten we did in commit 2dfb40121ee8 ("selftests: bpf:
> prepare for break up of verifier tests") for verifier: create
> scaffolding to support dedicated files and slowly move the tests into
> separate files.
>
> The first patch adds scaffolding, subsequent patches move progs into
> separate files.
>
> In theory, many of the standalone tests can be migrated to this new
> framework as well. They get the benefit of common CHECK macro and
> bpf_find_map function which a lot of standalone tests need to redefine.
>
> v2 changes:
> * added cover letter, added more description about file structure
>
> Stanislav Fomichev (7):
> selftests: bpf: break up test_progs - preparations
> selftests: bpf: break up test_progs - pkt access
> selftests: bpf: break up test_progs - xdp
> selftests: bpf: break up test_progs - stackmap
> selftests: bpf: break up test_progs - tracepoint
> selftests: bpf: break up test_progs - spinlock
> selftests: bpf: break up test_progs - misc
Looks good, thanks for bringing some structure into selftests! Series
failed to apply cleanly on the last patch though:
Switched to a new branch 'bpf-split-prog-tests'
Applying: selftests: bpf: break up test_progs - preparations
Applying: selftests: bpf: break up test_progs - pkt access
Applying: selftests: bpf: break up test_progs - xdp
Applying: selftests: bpf: break up test_progs - stackmap
Applying: selftests: bpf: break up test_progs - tracepoint
Applying: selftests: bpf: break up test_progs - spinlock
Applying: selftests: bpf: break up test_progs - misc
fatal: sha1 information is lacking or useless (tools/testing/selftests/bpf/test_progs.c).
error: could not build fake ancestor
Last commit in that file before this series is your ebace0e981b2
("selftests/bpf: use __bpf_constant_htons in test_prog.c for flow
dissector"), please respin with a fresh rebase.
Thanks,
Daniel
next prev parent reply other threads:[~2019-03-02 0:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 23:24 [PATCH bpf-next v2 0/7] selftests: bpf: break up test_progs Stanislav Fomichev
2019-02-28 23:24 ` [PATCH bpf-next v2 1/7] selftests: bpf: break up test_progs - preparations Stanislav Fomichev
2019-02-28 23:24 ` [PATCH bpf-next v2 2/7] selftests: bpf: break up test_progs - pkt access Stanislav Fomichev
2019-02-28 23:24 ` [PATCH bpf-next v2 3/7] selftests: bpf: break up test_progs - xdp Stanislav Fomichev
2019-02-28 23:24 ` [PATCH bpf-next v2 4/7] selftests: bpf: break up test_progs - stackmap Stanislav Fomichev
2019-02-28 23:24 ` [PATCH bpf-next v2 5/7] selftests: bpf: break up test_progs - tracepoint Stanislav Fomichev
2019-02-28 23:24 ` [PATCH bpf-next v2 6/7] selftests: bpf: break up test_progs - spinlock Stanislav Fomichev
2019-02-28 23:24 ` [PATCH bpf-next v2 7/7] selftests: bpf: break up test_progs - misc Stanislav Fomichev
2019-03-01 6:27 ` [PATCH bpf-next v2 0/7] selftests: bpf: break up test_progs Song Liu
2019-03-02 0:00 ` Daniel Borkmann [this message]
2019-03-02 0:58 ` Stanislav Fomichev
-- strict thread matches above, loose matches on Subject: below --
2019-03-02 3:40 Stanislav Fomichev
2019-03-02 3:41 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3b9965e-b987-a36a-e870-d8f8bb804262@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).