From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A576420F4 for ; Wed, 5 Jul 2023 09:34:29 +0000 (UTC) Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79DE31711 for ; Wed, 5 Jul 2023 02:34:27 -0700 (PDT) Received: from [141.14.220.45] (g45.guest.molgen.mpg.de [141.14.220.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 285AB61E5FE03; Wed, 5 Jul 2023 11:33:56 +0200 (CEST) Message-ID: Date: Wed, 5 Jul 2023 11:33:55 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: prevent call trace during reload Content-Language: en-US To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Przemek Kitszel References: <20230705040510.906029-1-michal.swiatkowski@linux.intel.com> From: Paul Menzel In-Reply-To: <20230705040510.906029-1-michal.swiatkowski@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Dear Michal, Thank you for your patch. Am 05.07.23 um 06:05 schrieb Michal Swiatkowski: > Calling ethtool during reload can lead to call trace, because VSI isn't > configured for some time, but netdev is alive. […] > Call trace before fix: > [66303.926205] BUG: kernel NULL pointer dereference, address: 0000000000000000 […] I’d be more specific in the commit message summary/title: ice: prevent NULL pointer deref during reload […] Kind regards, Paul