From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [patch net-next v7 03/13] net: sched: avoid usage of tp->q in
 tcf_classify
Date: Thu, 11 Jan 2018 06:57:26 -0700
Message-ID: <c3dbf4a3-6756-cde3-8d5f-241d01f9a207@gmail.com>
References: <20180109140731.1022-1-jiri@resnulli.us>
 <20180109140731.1022-4-jiri@resnulli.us>
 <8e52b826-c5b6-e144-b292-f7184d45f577@gmail.com>
 <20180111094023.GC2053@nanopsycho.orion>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        michael.chan@broadcom.com, ganeshgr@chelsio.com,
        saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com,
        idosch@mellanox.com, jakub.kicinski@netronome.com,
        simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com,
        john.hurley@netronome.com, alexander.h.duyck@intel.com,
        ogerlitz@mellanox.com, john.fastabend@gmail.com,
        daniel@iogearbox.net
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f68.google.com ([74.125.83.68]:33655 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932439AbeAKN53 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 11 Jan 2018 08:57:29 -0500
Received: by mail-pg0-f68.google.com with SMTP id i196so2236883pgd.0
        for <netdev@vger.kernel.org>; Thu, 11 Jan 2018 05:57:29 -0800 (PST)
In-Reply-To: <20180111094023.GC2053@nanopsycho.orion>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 1/11/18 2:40 AM, Jiri Pirko wrote:
> Wed, Jan 10, 2018 at 05:17:28PM CET, dsahern@gmail.com wrote:
>> On 1/9/18 7:07 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox.com>
>>>
>>> Use block index in the messages instead.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>>> ---
>>>  net/sched/cls_api.c | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>>> index 9b45950..31e91dc 100644
>>> --- a/net/sched/cls_api.c
>>> +++ b/net/sched/cls_api.c
>>> @@ -672,8 +672,9 @@ int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
>>>  #ifdef CONFIG_NET_CLS_ACT
>>>  reset:
>>>  	if (unlikely(limit++ >= max_reclassify_loop)) {
>>> -		net_notice_ratelimited("%s: reclassify loop, rule prio %u, protocol %02x\n",
>>> -				       tp->q->ops->id, tp->prio & 0xffff,
>>> +		net_notice_ratelimited("%u: reclassify loop, rule prio %u, protocol %02x\n",
>>
>> if you are dumping index instead of prio shouldn't the 'rule prio' above
>> be adjusted?
> 
> I'm not! Why do you think so?
> 
> "%u:" is tp->chain->block->index
> "prio %u" is tp->prio & 0xffff
> "%02x" is ntohs(tp->protocol)
> 

Never mind. scanned that too quickly.