From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, Chris Mi <cmi@nvidia.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
jiri@nvidia.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency
Date: Fri, 29 Jan 2021 12:44:59 -0800 [thread overview]
Message-ID: <c3eab4cb5c401a0273bf3b391d1b72dd46ee9921.camel@kernel.org> (raw)
In-Reply-To: <20210129123009.3c07563d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 2021-01-29 at 12:30 -0800, Jakub Kicinski wrote:
> On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
> > Instead of discussing it several days, maybe it's better to review
> > current patch, so that we can move forward :)
>
> It took you 4 revisions to post a patch which builds cleanly and now
> you want to hasten the review? My favorite kind of submission.
>
> The mlxsw core + spectrum drivers are 65 times the size of psample
> on my system. Why is the dependency a problem?
>
> What's going to make sure the module gets loaded when it's needed?
The issue is with distros who ship modules independently.. having a
hard dependency will make it impossible for basic mlx5_core.ko users to
load the driver when psample is not installed/loaded.
I prefer to have 0 dependency on external modules in a HW driver.
Thanks,
Saeed.
next prev parent reply other threads:[~2021-01-29 20:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 1:45 [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency Chris Mi
2021-01-29 5:14 ` Cong Wang
2021-01-29 6:08 ` Chris Mi
2021-01-29 20:30 ` Jakub Kicinski
2021-01-29 20:44 ` Saeed Mahameed [this message]
2021-01-29 21:47 ` Jakub Kicinski
2021-01-30 14:42 ` Ido Schimmel
2021-02-01 1:37 ` Chris Mi
2021-02-01 18:08 ` Ido Schimmel
2021-02-08 7:03 ` Leon Romanovsky
2021-02-08 8:57 ` Ido Schimmel
2021-02-08 9:07 ` Leon Romanovsky
2021-02-08 17:07 ` Ido Schimmel
2021-02-09 6:47 ` Leon Romanovsky
2021-02-09 9:25 ` Or Gerlitz
2021-02-09 10:01 ` Leon Romanovsky
2021-02-09 10:49 ` Or Gerlitz
2021-02-11 5:09 ` Saeed Mahameed
2021-02-11 21:59 ` Ido Schimmel
2021-02-12 0:41 ` Saeed Mahameed
2021-01-29 21:50 ` Jakub Kicinski
2021-01-30 2:35 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3eab4cb5c401a0273bf3b391d1b72dd46ee9921.camel@kernel.org \
--to=saeed@kernel.org \
--cc=cmi@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).